Closed
Bug 1252286
Opened 8 years ago
Closed 8 years ago
Use Android's Wikipedia search icon for all locales
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
4.0
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
rnewman
:
review+
tecgirl
:
ui-review+
|
Details | Review |
Bug 1179109 updates all of the Wikipedia assets to a 96x96 icon (even though the XML shows 16x16). We're using a 90x90 image on iOS, so our current Wikipedia assets are slightly worse quality than the ones on Android. We originally diverged from Android since iOS had the higher res icons across all locales first. Since it looks like Android has caught up, I propose we drop the Wikipedia icon we're using on iOS and just pull in Android's. As of bug 1243847, this should be as simple as removing the wikipedia.xml overlay.
|
Assignee | |
Comment 1•8 years ago
|
||
Removes our 90x90 iOS Wikipedia image and just uses the 96x96 icon we import directly from Android.
Attachment #8726974 -
Flags: ui-review?(randersen)
Attachment #8726974 -
Flags: review?(rnewman)
|
||
Comment 2•8 years ago
|
||
Question about non-English locales.
|
|
||
Updated•8 years ago
|
Attachment #8726974 -
Flags: review?(rnewman) → review+
|
||
Updated•8 years ago
|
Attachment #8726974 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/345aea11fd54820b81a30fbee56d6793d4973905
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•