Remove gfx/thebes/Makefile.in

RESOLVED FIXED in Firefox 47

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

unspecified
mozilla47

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8725015 [details]
MozReview Request: Bug 1252302 - Remove gfx/thebes/Makefile.in; r?gps

This requires converting genTables.py into something moz.build can call
into.

Review commit: https://reviewboard.mozilla.org/r/37275/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37275/
Attachment #8725015 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8725015 [details]
MozReview Request: Bug 1252302 - Remove gfx/thebes/Makefile.in; r?gps

https://reviewboard.mozilla.org/r/37275/#review34039

::: gfx/thebes/genTables.py:16
(Diff revision 1)
> +def main(args):
> +    if (len(args)):
> +        func = globals().get(args[0])
> +        if func:
> +            return func(sys.stdout, *args[1:])
> +
> +
> +if __name__ == '__main__':
> +    sys.exit(main(sys.argv[1:]))

You don't actually need this since GENERATED_FILES calls into generate() directly, right?

I'm not a huge fan of the globals() foo. If there is only 1 thing this script does, why not assert that and just call into generate()?
Attachment #8725015 - Flags: review?(gps)
(Assignee)

Comment 3

2 years ago
(In reply to Gregory Szorc [:gps] from comment #2)
> ::: gfx/thebes/genTables.py:16
> (Diff revision 1)
> > +def main(args):
> > +    if (len(args)):
> > +        func = globals().get(args[0])
> > +        if func:
> > +            return func(sys.stdout, *args[1:])
> > +
> > +
> > +if __name__ == '__main__':
> > +    sys.exit(main(sys.argv[1:]))
> 
> You don't actually need this since GENERATED_FILES calls into generate()
> directly, right?
> 
> I'm not a huge fan of the globals() foo. If there is only 1 thing this
> script does, why not assert that and just call into generate()?

Good point - I was looking at variables.py for reference on how to do GENERATED_FILES scripts, and mistakenly thought all that boilerplate was necessary. We can just use a simple main implementation to support running manually from the commandline.
(Assignee)

Comment 4

2 years ago
Comment on attachment 8725015 [details]
MozReview Request: Bug 1252302 - Remove gfx/thebes/Makefile.in; r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37275/diff/1-2/
Attachment #8725015 - Flags: review?(gps)

Comment 5

2 years ago
Comment on attachment 8725015 [details]
MozReview Request: Bug 1252302 - Remove gfx/thebes/Makefile.in; r?gps

https://reviewboard.mozilla.org/r/37275/#review34265

::: gfx/thebes/genTables.py:18
(Diff revision 2)
> +        print >> sys.stderr, "Usage: genTables.py <header.h>"

Let's at least try to be Python 3 compatibile.

print("...", file=sys.stderr)
Attachment #8725015 - Flags: review?(gps) → review+
(Assignee)

Comment 6

2 years ago
(In reply to Gregory Szorc [:gps] from comment #5)
> Comment on attachment 8725015 [details]
> ::: gfx/thebes/genTables.py:18
> (Diff revision 2)
> > +        print >> sys.stderr, "Usage: genTables.py <header.h>"
> 
> Let's at least try to be Python 3 compatibile.
> 
> print("...", file=sys.stderr)

Done.

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1be1bac73a4f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.