1252305 - Tabs flow below toolbar if a toolbarbutton type="menu-button" is in the tabbar-toolbar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[alta88]

Customizing and placing the print button, for example, in the tabs toolbar will cause the toolbar to shrink, and tab borders flow outside the tabs toolbar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: dropmarker.patch

My bad, I should have to check also the toolbarbuttons when I fixed the menulist dropmarker.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8725286 [details] [diff] [review]
dropmarker.patch

Review of attachment 8725286 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8725286 [details] [diff] [review]
dropmarker.patch

Not sure when c-c reopens, so adding the approval now

[Approval Request Comment]
Regression caused by (bug #): 1244570 which is in TB 45
User impact if declined: tabs not correctly connected to the toolbar
Testing completed (on c-c, etc.): not yet
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Kent James (:rkent)]

With c-c closed but close to releases, let's land this in aurora.

Comment 5

[Kent James (:rkent)]

Comment on attachment 8725286 [details] [diff] [review]
dropmarker.patch

Pushed to aurora as pretest for TB 45 checkin since c-c is closed:

http://hg.mozilla.org/releases/comm-aurora/rev/511f19bc675a

Comment 6

[Kent James (:rkent)]

Comment on attachment 8725286 [details] [diff] [review]
dropmarker.patch

(I believe you meant esr45 and not esr38)

http://hg.mozilla.org/releases/comm-esr45/rev/f2cd3d2e2b69
http://hg.mozilla.org/releases/comm-beta/rev/151317bf1995

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/902f0f9fcdc14f1858a768e52512bca7aca94c65
Bug 1252305 - Use a background image for the .toolbarbutton-menubutton-dropmarker. r=mkmelin