tweak release runner to handle releases differently in the context of promotion to point both old and new worlds to the same ship-it instance

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mtabara, Assigned: mtabara)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Per IRC conversation with rail:

18:03:35 <mtabara> is that a temporary hack that we do on release-runner to make sure it doesn't pick up but beta releases?
18:08:34 <rail> that patch should make release runner handle firefox betas only,
18:08:51 <rail> the patch is for "default"
18:09:16 <rail> we also need something similar for "old-release-runner" to make it handle the other ones
18:09:26 <rail> everything except firefox betas
18:09:40 <rail> so we can point them to the same ship it instance
18:10:00 <rail> the patches may differ a bit
Attachment #8725516 - Attachment is obsolete: true
Attachment #8725516 - Flags: review?(rail)
Attachment #8725518 - Flags: review?(rail)
Comment on attachment 8725518 [details] [diff] [review]
Tweak release runner in build-promotion to take into account but betas only

Review of attachment 8725518 [details] [diff] [review]:
-----------------------------------------------------------------

Can you also prep another patch for http://hg.mozilla.org/build/tools/file/old-release-runner/buildfarm/release/release-runner.py (old-release-runner branch) with the same logic, but different patterns to handle:

* Non beta desktop releases
* Fennec
* Thunderbird

so we can ran 2 release runner instances in parallel and point them to the same ship-it instance?

::: buildfarm/release/release-runner.py
@@ +50,5 @@
>  
>  
> +RELEASE_PATTERNS = [
> +    r"Firefox-\d+\.0b\d+-build\d+"
> +]

Can you add comments what this is?
* refactoring upon Rail's comments
* I've also added comments for two of the constants chained to bug 1251761
* will follow-up with a patch for the oldrelease-runner branch as well
Attachment #8725874 - Flags: review?(rail)
Assignee

Updated

3 years ago
Attachment #8725518 - Attachment is obsolete: true
Attachment #8725518 - Flags: review?(rail)

Updated

3 years ago
Attachment #8725874 - Flags: review?(rail) → review+
Comment on attachment 8725874 [details] [diff] [review]
Tweak release runner in build-promotion to take into account but betas only

Review of attachment 8725874 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/build/tools/rev/9a9fa4e89121
Attachment #8725874 - Flags: checked-in+
While building the regexe for the oldrelease-runner branch I realized we can improve the regex for build-promotion world to:

a) take into consideration other digits than 0 (so not only 55.0 but also 55.1 or 55.2)

b) take into consideration betas for dot-releases. (such as 52.0.2b4)

Honestly I didn't know the latter exist, but just found a real example: 38.0.5b4 for both Fennec and Firefox.

I know this whole bug holds but a temporary solution till we drag release promotion out there for all releases but thought it's a good idea to tweak these two changes in advance, just in case.
Attachment #8726007 - Flags: review?(rail)
Comment on attachment 8726007 [details] [diff] [review]
Improve the ship-only-firefox-betas regex in release-promotion

Review of attachment 8726007 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Mihai Tabara [:mtabara] from comment #6)
> a) take into consideration other digits than 0 (so not only 55.0 but also
> 55.1 or 55.2)

I explicitly used 0 because it's always 0 for betas. 

> b) take into consideration betas for dot-releases. (such as 52.0.2b4)

Nevah! 404. IOError, ValueError, SystemError, reboot!

> Honestly I didn't know the latter exist, but just found a real example:
> 38.0.5b4 for both Fennec and Firefox.

Where?! http://ftp.mozilla.org/pub/firefox/releases/38.0.5b4 is 404

The change doesn't hurt, so r+.
Attachment #8726007 - Flags: review?(rail) → review+
Example of Fennec 38.0.5b4 build1 and of Firefox 38.0.5b3 build1

http://people.mozilla.org/~mtabara/twisted_example_of_beta.png
Flags: needinfo?(rail)
wot?! really?! no way! :D
Flags: needinfo?(rail)
Assignee

Updated

3 years ago
Attachment #8726007 - Attachment is obsolete: true

Updated

3 years ago
Blocks: 1253366
Will finish this today.
Follow-up patch to tweak the oldrelease-runner branch that we currently use in production to temporary filter out the firefox betas from the releases.

The patch is very similar to the one from default branch. However I haven't test it yet.
Attachment #8726500 - Flags: review?(rail)
Comment on attachment 8726500 [details] [diff] [review]
Tweak old release runner to take into account everything except firefox desktop betas

Review of attachment 8726500 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.py
@@ +43,5 @@
> +    r"Firefox-\d+\.\d+(\.\d+)?(esr)?-build\d+",
> +    # all Fennec betas
> +    r"Fennec-\d+\.0b\d+-build\d+",
> +    # all Fennec non-betas
> +    r"Fennec-\d+\.\d+(\.\d+)?(esr)?-build\d+",

no fennec on ers, but it won't hurt

@@ +47,5 @@
> +    r"Fennec-\d+\.\d+(\.\d+)?(esr)?-build\d+",
> +    # all Thunderbird betas
> +    r"Thunderbird-\d+\.0b\d+-build\d+",
> +    # all Thunderbird non-betas
> +    r"Thunderbird-\d+\.\d+(\.\d+)?(esr)?-build\d+",

No tb on esr, but it won't hurt
Attachment #8726500 - Flags: review?(rail) → review+
Comment on attachment 8726500 [details] [diff] [review]
Tweak old release runner to take into account everything except firefox desktop betas

Review of attachment 8726500 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your comments Rail. I removed the (esr) rule from the regexes for both Fennec/Thunderbird and pushed to upstream in the old-release-runner branch.

http://hg.mozilla.org/build/tools/changeset/5645f8176283
Attachment #8726500 - Flags: checked-in+
Assignee

Updated

3 years ago
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Assignee

Updated

3 years ago
See Also: → 1262073
See Also: → 1340548
See Also: → 1338150
You need to log in before you can comment on or make changes to this bug.