Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: Felipe)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(e10s+, firefox-esr4545+ fixed)

Details

Attachments

(1 attachment)

Gecko 45 currently determines e10s availability by checking whether app.update.channel is set to "release" or not, which means it'll be available to ESR45 users. I strongly suspect that this isn't something we want :)

Note that we need bug 1252328 to be fixed first or we'll have a pile of permafail on ESR45 once this lands.
(Assignee)

Comment 1

2 years ago
Let me make the summary more clear so there's no confusion. E10s is not enabled by default on esr, all the prefs are set to false. We've been careful to actually block e10s on release (to avoid people from messing with prefs) and we would like to extend this block to ESR.
Summary: Disable e10s on ESR45 → Disallow e10s on ESR45
Felipe, could you take care of that?
This should land today. Thanks
Flags: needinfo?(felipc)
(Assignee)

Comment 3

2 years ago
Created attachment 8725315 [details] [diff] [review]
disallow-e10s

This patch fully blocks e10s from being enabled. It's meant only for the ESR45 tree.

I could remove the entire function too but for minimal code change's sake, i figured it would be better to do it this way.
Flags: needinfo?(felipc)
Attachment #8725315 - Flags: review?(jmathies)

Comment 4

2 years ago
Comment on attachment 8725315 [details] [diff] [review]
disallow-e10s

approving for esr branch only.
Attachment #8725315 - Flags: review?(jmathies) → review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8725315 [details] [diff] [review]
disallow-e10s

Note that bug 1252328 needs to be fixed first before landing this, otherwise the e10s tests will try to activate e10s, and this will block them, causing them to go red.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: disallow users from toggling e10s
Fix Landed on Version: patch is specific for esr
Risk to taking this patch (and alternatives if risky): can't think of any outside of automated tests
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8725315 - Flags: approval-mozilla-esr45?

Updated

2 years ago
tracking-e10s: --- → +
Comment on attachment 8725315 [details] [diff] [review]
disallow-e10s

Approved for esr45 uplift, from comment 2, sounds like Sylvestre wants this in asap for the build tomorrow. We should hide the tests from bug 1252328 for now.
Attachment #8725315 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
(Assignee)

Comment 7

2 years ago
Do I land this on the default branch of https://hg.mozilla.org/releases/mozilla-esr45/ ?
Flags: needinfo?(lhenry)
Yes :P

https://hg.mozilla.org/releases/mozilla-esr45/rev/051d29d3da2d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → ---
status-firefox-esr45: --- → fixed
tracking-firefox-esr45: --- → ?
Flags: needinfo?(lhenry)
Resolution: --- → FIXED
As it is not a feature available for regular users (unlike Service Workers & Hello), I am NOT going to add this in the release notes.
tracking-firefox-esr45: ? → 45+
You need to log in before you can comment on or make changes to this bug.