Closed Bug 1252343 Opened 4 years ago Closed 4 years ago

Make mReader a const member of MediaDecoderStateMachine

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

After fixing bug 1252341, we can make it const.
Assignee: nobody → jwwang
Depends on: 1252341
Comment on attachment 8725073 [details]
MozReview Request: Bug 1252343. Part 1 - make mReader const. r=bechen.

https://reviewboard.mozilla.org/r/37329/#review33895
Attachment #8725073 - Flags: review?(bechen) → review+
Comment on attachment 8725074 [details]
MozReview Request: Bug 1252343. Part 2 - remove null checks for mReader which is const and never null. r=bechen.

https://reviewboard.mozilla.org/r/37331/#review33897

::: dom/media/MediaDecoderStateMachine.h:215
(Diff revision 1)
>    // Drop reference to mReader and mResource. Only called during shutdown dance.

Please help to modify the comment.
Attachment #8725074 - Flags: review?(bechen) → review+
Sure. Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/9d343ae304ec
https://hg.mozilla.org/mozilla-central/rev/fa8ef41d0830
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.