1252343 - Make mReader a const member of MediaDecoderStateMachine

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

After fixing bug 1252341, we can make it const.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252343. Part 1 - make mReader const. r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37329/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37329/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252343. Part 2 - remove null checks for mReader which is const and never null. r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37331/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37331/

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8725073 [details]
MozReview Request: Bug 1252343. Part 1 - make mReader const. r=bechen.

https://reviewboard.mozilla.org/r/37329/#review33895

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8725074 [details]
MozReview Request: Bug 1252343. Part 2 - remove null checks for mReader which is const and never null. r=bechen.

https://reviewboard.mozilla.org/r/37331/#review33897

::: dom/media/MediaDecoderStateMachine.h:215
(Diff revision 1)
>    // Drop reference to mReader and mResource. Only called during shutdown dance.

Please help to modify the comment.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Sure. Thanks for the review!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d343ae304ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8ef41d0830

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d343ae304ec
https://hg.mozilla.org/mozilla-central/rev/fa8ef41d0830