1252344 - Remove unnecessary checks from MediaDecoderStateMachine::NeedToDecodeVideo()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We don't need to check IsVideoDecoding() twice.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252344. Part 1 - remove unnecessary checks from MediaDecoderStateMachine::NeedToDecodeVideo(). r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37545/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37545/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252344. Part 2 - remove unnecessary checks from MediaDecoderStateMachine::NeedToDecodeAudio(). r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37547/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37547/

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8725514 [details]
MozReview Request: Bug 1252344. Part 1 - remove unnecessary checks from MediaDecoderStateMachine::NeedToDecodeVideo(). r=bechen.

https://reviewboard.mozilla.org/r/37545/#review34091

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8725515 [details]
MozReview Request: Bug 1252344. Part 2 - remove unnecessary checks from MediaDecoderStateMachine::NeedToDecodeAudio(). r=bechen.

https://reviewboard.mozilla.org/r/37547/#review34093

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfc0b3c2844d
https://hg.mozilla.org/integration/mozilla-inbound/rev/1655d7bc34e1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfc0b3c2844d
https://hg.mozilla.org/mozilla-central/rev/1655d7bc34e1