1252360 - Remove the |(mState != DECODER_STATE_SEEKING || mDecodeToSeekTarget)| check from MediaDecoderStateMachine::NeedToDecodeAudio()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Because NeedToDecodeVideo() doesn't have it. The logic of NeedToDecode{Audio,Video} should be symmetric/similar to each other.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252360 - remove some check from NeedToDecodeAudio(). r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37785/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37785/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8726048 [details]
MozReview Request: Bug 1252360 - remove some check from NeedToDecodeAudio(). r=bechen.

https://reviewboard.mozilla.org/r/37785/#review34349

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4566366ea618

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6990248dc4ec

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6990248dc4ec