Remove the |(mState != DECODER_STATE_SEEKING || mDecodeToSeekTarget)| check from MediaDecoderStateMachine::NeedToDecodeAudio()

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Because NeedToDecodeVideo() doesn't have it. The logic of NeedToDecode{Audio,Video} should be symmetric/similar to each other.
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
(Assignee)

Comment 1

3 years ago
Created attachment 8726048 [details]
MozReview Request: Bug 1252360 - remove some check from NeedToDecodeAudio(). r=bechen.

Review commit: https://reviewboard.mozilla.org/r/37785/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37785/
Attachment #8726048 - Flags: review?(bechen)
Attachment #8726048 - Flags: review?(bechen) → review+
Comment on attachment 8726048 [details]
MozReview Request: Bug 1252360 - remove some check from NeedToDecodeAudio(). r=bechen.

https://reviewboard.mozilla.org/r/37785/#review34349
(Assignee)

Comment 3

3 years ago
Thanks!
(Assignee)

Updated

3 years ago
Blocks: 1253184

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6990248dc4ec
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.