Closed Bug 1252397 Opened 10 years ago Closed 10 years ago

Only show bookmarks empty panel state for top-level empty mobile bookmarks and no desktop bookmarks

Categories

(Firefox for iOS :: Home screen, defect)

Product:
Firefox for iOS
Component:
Home screen
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 3.0+ ---

People

(Reporter: fluffyemily, Assigned: bmunar)

References

Details

Attachments

(2 files)

EmptyUnsortedBookmarksFolder.png
109.88 KB, image/png
Details
PR
48 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review
See attachment. When clicking on Unsorted Bookmarks folder in my synced desktop bookmarks, I am presented with to the empty bookmarks panel, with no way back to my other bookmarks (i.e. no back folder)
Blocks: 1183214
We shouldn't be showing the empty panel state at all in this case.
Hardware: Other → All
Summary: No way back out of empty Unsorted Bookmarks folder → Only show bookmarks empty panel state for top-level empty mobile bookmarks and no desktop bookmarks
Assignee: nobody → bmunar
Attached file PR —
for whoever can get to it first, one-liner
Attachment #8725325 - Flags: review?(sleroux)
Attachment #8725325 - Flags: review?(etoop)
Attachment #8725325 - Flags: review?(bnicholson)
Attachment #8725325 - Flags: review?(rnewman)
Comment on attachment 8725325 [details] [review] PR I prefer my conditional; take a look at the PR.
Attachment #8725325 - Flags: review?(sleroux)
Attachment #8725325 - Flags: review?(rnewman)
Attachment #8725325 - Flags: review?(etoop)
Attachment #8725325 - Flags: review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8725325 - Flags: review?(bnicholson)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: