Closed Bug 1252418 Opened 4 years ago Closed 4 years ago

Inspector sidebar collapse icon is blurry in vertical mode on windows 10

Categories

(DevTools :: Inspector, defect, P1)

Unspecified
Windows 10
defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: pbro, Assigned: jdescottes)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(3 files)

Attached image horizontal.PNG
Bug 1189492 made the inspector sidebar collapse feature also work when docked to the side.
I just tested it in FF47 now (on windows10) and realized that the icon used in vertical mode is sort of blurry.
I'll attach both icons to illustrate the difference.
This might come from the fact that the icon is css transformed.
Attached image vertical.PNG
Ah, interesting fact, if you apply the rotate(90deg) transform to the image inside the toolbarbutton instead of on the toolbarbutton itself, then the image is crisp!
Flagging as P1 so we find a workaround quickly before this new feature lands.
Priority: -- → P1
Whiteboard: [btpp-fix-now]
Apparently applying rotate(90) on #inspector-pane-toggle makes the icon blurry
on some platforms (at least windows 10).

Applying the same rotate directly on the image seems to fix the issue.

Review commit: https://reviewboard.mozilla.org/r/37361/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37361/
Attachment #8725204 - Flags: review?(pbrosset)
Comment on attachment 8725204 [details]
MozReview Request: Bug 1252418 - Apply transform(90) on image to fix blurry icon;r=pbrosset

https://reviewboard.mozilla.org/r/37361/#review33921

Works beautifully for me on windows 10. Thanks for the prompt fix!
Attachment #8725204 - Flags: review?(pbrosset) → review+
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/31134c5883ff
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.