1252497 - Make hot reloading work on windows

Status: RESOLVED WONTFIX

(DevTools :: Framework, defect, P2)

Description

[James Long (:jlongster)]

Right now, hot reloading depends on the fact that the files in the objdir are actually symlinked to the srcdir files. This means that it doesn't work at all on windows, where I'm assuming the files are copied.

A straight-forward hack would be to make the hot reloader actually copy the file on windows. I don't know if that's too dangerous and would mess with the build system though. It seems like it should be fine; the build system will still check modification times of files and a build should update all objdir files regardless.

That should only take a few lines of code, if we want to try it.

Comment 1

[James Long (:jlongster)]

I'm a little concerned at doing the above though, the more I think about it. If you use the reload addon, we might accidentally mess with actual user files. Theoretically the src and dest paths would be the same, and we could skip copying it, but there might be times when we for some reason overwrite a valid file. Seems pretty scary to start doing that.

Not sure what else we could do. The fundamental problem is that a file's resource URI is used throughout the tools, so if you hot reload a CSS file and the console changes, and tools that aren't loaded yet should see the updated file when they are loaded. Otherwise we could replace the resource URIs with hardcoded file:// paths when hot reloading, which would fix the issue.

Comment 2

[Soledad Penades [:sole] [:spenades]]

It is my understanding that we removed the hot reload functionality, so I'm going to close this. Please reopen if I'm wrong ;)