Closed Bug 1252499 Opened 4 years ago Closed 4 years ago

Only insert blank tile if actually needed ( < 0 isn't the same as <= 0 )

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed
fennec 47+ ---

People

(Reporter: ahunt, Assigned: ahunt)

References

Details

Attachments

(1 file)

Bug introduced in:
https://hg.mozilla.org/integration/fx-team/rev/86d110d3d0eb17bfbaa3f8d4a7287466621ad710#l2.124

This leads to a "blank" tile being shown once we fill the topsites grid (but before we have any real overflow content) - this tile opens to about:blank, and crashes when long-pressed (since we don't provide history/bookmark info for it).
Assignee: nobody → ahunt
Depends on: 760956
tracking-fennec: --- → ?
Comment on attachment 8725311 [details]
MozReview Request: Bug 1252499 - only insert blank tile when really needed r=liuche

https://reviewboard.mozilla.org/r/37407/#review33981
Attachment #8725311 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/18832ab14128
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
tracking-fennec: ? → 47+
You need to log in before you can comment on or make changes to this bug.