Closed
Bug 1252499
Opened 8 years ago
Closed 8 years ago
Only insert blank tile if actually needed ( < 0 isn't the same as <= 0 )
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Firefox for Android Graveyard
Awesomescreen
Tracking
(firefox47 fixed, fennec47+)
RESOLVED
FIXED
Firefox 47
People
(Reporter: ahunt, Assigned: ahunt)
References
Details
Attachments
(1 file)
Bug introduced in: https://hg.mozilla.org/integration/fx-team/rev/86d110d3d0eb17bfbaa3f8d4a7287466621ad710#l2.124 This leads to a "blank" tile being shown once we fill the topsites grid (but before we have any real overflow content) - this tile opens to about:blank, and crashes when long-pressed (since we don't provide history/bookmark info for it).
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37407/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37407/
Attachment #8725311 -
Flags: review?(liuche)
|
||
Updated•8 years ago
|
tracking-fennec: --- → ?
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8725311 [details] MozReview Request: Bug 1252499 - only insert blank tile when really needed r=liuche https://reviewboard.mozilla.org/r/37407/#review33981
Attachment #8725311 -
Flags: review?(liuche) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/18832ab14128eaa68b56fc85f2b5284d909982fa Bug 1252499 - only insert blank tile when really needed r=liuche
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/18832ab14128
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
tracking-fennec: ? → 47+
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•