Closed Bug 1252579 Opened 8 years ago Closed 6 years ago

Smart Button should keep a separate child node for text

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: zbraniecki, Unassigned)

Details

Currently, smart button sets its text as a textContent on the <smart-button> element and when using localization, it sets the `data-l10n-id` attribute on the element.

This breaks when the code also tries to define a child element for an icon, because L20n does not allow external code to operate on the child node of a localizable node (with the exception of DOMOverlays).

So, instead of:

<smart-button data-l10n-id="foo">
  <div class="icon"></div>
</smart-button>

we should have:

<smart-button>
  <span data-l10n-id="foo"></span>
  <div class="icon"></div>
</smart-button>
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.