Closed Bug 1252601 Opened 4 years ago Closed 4 years ago

Handle requests errors gracefully when submitting telemetry data

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

We have the infrastructure in place to attempt to resubmit data in case of network errors, but we still need to handle those errors more gracefully.
e.g.

ConnectionError: HTTPConnectionPool(host='52.88.27.118', port=80): Max retries exceeded with url: /build-metrics-dev (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f10d01bfb50>: Failed to establish a new connection: [Errno 113] No route to host',))

  File "/build/mozilla-central/build/mach_bootstrap.py", line 378, in post_dispatch_handler
    headers={'Content-Type': 'application/json'})
  File "/build/mozilla-central/python/requests/requests/sessions.py", line 511, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/build/mozilla-central/python/requests/requests/sessions.py", line 468, in request
    resp = self.send(prep, **send_kwargs)
  File "/build/mozilla-central/python/requests/requests/sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "/build/mozilla-central/python/requests/requests/adapters.py", line 437, in send
    raise ConnectionError(e, request=request)
Assignee: nobody → dminor
This catches the exception and prevents further attempts to post to
telemetry in this command invocation.

Review commit: https://reviewboard.mozilla.org/r/37905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37905/
Attachment #8726288 - Flags: review?(gps)
Attachment #8726288 - Flags: review?(gps) → review+
Comment on attachment 8726288 [details]
MozReview Request: Bug 1252601 - Handle requests errors gracefully when submitting telemetry data r?gps

https://reviewboard.mozilla.org/r/37905/#review34537
https://hg.mozilla.org/mozilla-central/rev/79914dafd201
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.