1252609 - |mach marionette-test| ignores --binary option

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect)

Description

[Syd Polk :sydpolk]

+++ This bug was initially created as a clone of Bug #1252608 +++

+++ This bug was initially created as a clone of Bug #1252586 +++

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822

Steps to reproduce:

Ran ./mach marionette --binary /Applications/Firefox.app/Contents/MacOS/firefox


Actual results:

Mach fails with an error,
Exception: Binary expected at path_to_obj-x86_64-apple-darwin15.3.0/dist/Nightly.app/Contents/MacOS/firefox does not exist.


Expected results:

The tests should run with the binary specified with the --binary option.

Comment 1

[Syd Polk :sydpolk]

Attachment: MozReview Request: Bug 1252609 - Fix |mach marionette-test --binary| - r?automatedtester, r?gps

Review commit: https://reviewboard.mozilla.org/r/37469/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37469/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8725405 [details]
MozReview Request: Bug 1252609 - Fix |mach marionette-test --binary| - r?automatedtester, r?gps

https://reviewboard.mozilla.org/r/37469/#review34007

::: testing/marionette/mach_commands.py:124
(Diff revision 1)
> +        if kwargs['binary'] is None:

Is the point of this to allow people to use firefox without having to build? There is an implicit requirement from Mach that there is a build unless gps has a way to override `is_firefox` checks

Comment 3

[Syd Polk :sydpolk]

This started with firefox-ui-tests. Since firefox-ui-tests has moved into mozilla-central, it needs to be able to run with explicit --installer/--binary and --tests parameters. We decided to support that in the mach command.

You can always instantiate a virtualenv and run python setup.py develop to run marionette-test, so maybe there is no desire to be able to do this from ./mach.

Since the code for firefox-ui/mach_commands.py (and for that matter, the external-media-tests version as well), I updated all three.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8725405 [details]
MozReview Request: Bug 1252609 - Fix |mach marionette-test --binary| - r?automatedtester, r?gps

https://reviewboard.mozilla.org/r/37469/#review34047

::: testing/marionette/mach_commands.py:124
(Diff revision 1)
> +        if kwargs['binary'] is None:

Same nit as bug 1252586.

It is unfortunate you had to file 3 bugs for what is essentially the same problem. This is a reason I don't like code review revolving around Bugzilla.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Gregory Szorc [:gps] from comment #4)
> It is unfortunate you had to file 3 bugs for what is essentially the same
> problem. This is a reason I don't like code review revolving around Bugzilla.

A single bug within the mach component might also have been ok here.

Comment 6

[Syd Polk :sydpolk]

https://reviewboard.mozilla.org/r/37469/#review34007

> Is the point of this to allow people to use firefox without having to build? There is an implicit requirement from Mach that there is a build unless gps has a way to override `is_firefox` checks

Henrik adequately justified this in the Bugzilla.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

And as tested with no obj dir and a mach configure step, it will work. So no need to build Firefox before.

Comment 8

[David Burns :automatedtester]

I am happy for there to be a need for a build and for the --binary to just go between different objdirs

Comment 9

[Syd Polk :sydpolk]

Don't we still need the fix?