Closed Bug 1252629 Opened 8 years ago Closed 8 years ago

Restoring closed tab with a redirected page comes back with the pre-redirected URL & breaks things

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox45 - fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: jld, Unassigned)

References

Details

(Keywords: regression) 

STR: Open a new tab and go to a URL that redirects, like https://bugzil.la/970676; then close the tab; then un-close it (Cmd-Shift-T, Ctrl-Shift-T, etc.).

Expected: The tab comes back as it was.

Actual: The tab comes back with the pre-redirect URL in the URL bar, and none of the subresources are loaded because they're given as relative URLs and now they're being resolved relative to the pre-redirected page URL (which does not return anything useful).

Seen on Mac nightly, build ID 20160301030237.  I haven't yet tried to reproduce on other OSes or to bisect the regression.
I can at least say this works correctly on 45, while I can reproduce on Nightly.
Keywords: regression, regressionwindow-wanted
I can reproduce on the 02-25 nightly on Windows as well. I wonder if it's e10s-specific...
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=fd90f5266bd50e711857089143f8e64e2477f660&tochange=56ed0ec901c08f0368a2d8c751795c14aa6a5a41


(In reply to :Gijs Kruitbosch from comment #1)
> I can at least say this works correctly on 45, while I can reproduce on
> Nightly.

This was b9 - it's broken on b10. We uplifted this.

Yoric/Dragana, can you investigate with some degree of urgency? Thanks.
Blocks: CVE-2016-1967
status-firefox45: --- → affected
status-firefox46: --- → affected
tracking-firefox45: --- → ?
Flags: needinfo?(dteller)
Flags: needinfo?(dd.mozilla)
Keywords: regressionwindow-wanted
There is is a patch for this it is in central, maybe in nightly (if not today than tomorrow) and there is a uplift approval request for beta and aurora.
Flags: needinfo?(dd.mozilla)
(In reply to Dragana Damjanovic [:dragana] from comment #5)
> There is is a patch for this it is in central, maybe in nightly (if not
> today than tomorrow) and there is a uplift approval request for beta and
> aurora.

From which bug / which rev is that?
(In reply to :Gijs Kruitbosch from comment #6)
> (In reply to Dragana Damjanovic [:dragana] from comment #5)
> > There is is a patch for this it is in central, maybe in nightly (if not
> > today than tomorrow) and there is a uplift approval request for beta and
> > aurora.
> 
> From which bug / which rev is that?

bug 1246956
Sorry, I can't take this. I'm already working on two teams at once at the moment and verging on exploding.
This should be fixed now everywhere by bug 1246956.
(I have tested it with nightly)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Flags: needinfo?(dteller)
You need to log in before you can comment on or make changes to this bug.