1252630 - Clean up the APZ reftest manifests

Status: RESOLVED WONTFIX

(Core :: Panning and Zooming, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Instead of putting skip-if(!asyncPan) at the beginning of each line in the manifests, we can skip them at the manifest-level instead. Would be a bit cleaner to parse that way.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8725420 [details] [diff] [review]
patch

Review of attachment 8725420 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the skip-if(!asyncZoom) put back

::: gfx/layers/apz/test/reftest/reftest.list
@@ +10,5 @@
>  # Different async zoom levels. Since the scrollthumb gets async-scaled in the
>  # compositor, the border-radius ends of the scrollthumb are going to be a little
>  # off, hence the fuzzy-if clauses.
> +fuzzy-if(B2G,98,82) == async-scrollbar-zoom-1.html async-scrollbar-zoom-1-ref.html
> +fuzzy-if(B2G,94,146) == async-scrollbar-zoom-2.html async-scrollbar-zoom-2-ref.html

we'll still need skip-if(!asyncZoom) on these two, because asyncZoom is a non-equal subset of asyncPan

@@ +15,3 @@
>  
>  # Meta-viewport tag support
> +== initial-scale-1.html initial-scale-1-ref.html

ditto

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f0e8cebe85

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7f0e8cebe85

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This has proved to be more hassle than it's worth thanks to the finicky way reftest annotations work.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6d4e1ef9cb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/590a4e9f938a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c6d4e1ef9cb