Clean up the APZ reftest manifests

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

({arch})

Trunk
Points:
---

Firefox Tracking Flags

(firefox47 wontfix, firefox48 wontfix)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Instead of putting skip-if(!asyncPan) at the beginning of each line in the manifests, we can skip them at the manifest-level instead. Would be a bit cleaner to parse that way.
(Assignee)

Comment 1

3 years ago
Created attachment 8725420 [details] [diff] [review]
patch
Attachment #8725420 - Flags: review?(bugmail.mozilla)
Comment on attachment 8725420 [details] [diff] [review]
patch

Review of attachment 8725420 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the skip-if(!asyncZoom) put back

::: gfx/layers/apz/test/reftest/reftest.list
@@ +10,5 @@
>  # Different async zoom levels. Since the scrollthumb gets async-scaled in the
>  # compositor, the border-radius ends of the scrollthumb are going to be a little
>  # off, hence the fuzzy-if clauses.
> +fuzzy-if(B2G,98,82) == async-scrollbar-zoom-1.html async-scrollbar-zoom-1-ref.html
> +fuzzy-if(B2G,94,146) == async-scrollbar-zoom-2.html async-scrollbar-zoom-2-ref.html

we'll still need skip-if(!asyncZoom) on these two, because asyncZoom is a non-equal subset of asyncPan

@@ +15,3 @@
>  
>  # Meta-viewport tag support
> +== initial-scale-1.html initial-scale-1-ref.html

ditto
Attachment #8725420 - Flags: review?(bugmail.mozilla) → review+
Keywords: arch
Whiteboard: [gfx-noted]

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f7f0e8cebe85
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Comment 5

3 years ago
This has proved to be more hassle than it's worth thanks to the finicky way reftest annotations work.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6d4e1ef9cb
status-firefox48: --- → wontfix
Resolution: FIXED → WONTFIX
Target Milestone: mozilla47 → ---
You need to log in before you can comment on or make changes to this bug.