don't check for updates unless mozApps is defined

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

unspecified
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

3 years ago
Without the mozApps API, it isn't possible to check for updates, so the runtime shouldn't try, or the attempt will throw an exception.  That isn't the end of the world, but it could mislead someone looking at a log.
Attachment #8725426 - Flags: review?(mcastelluccio)
Comment on attachment 8725426 [details] [diff] [review]
confirm mozApps is defined before checking for updates

Review of attachment 8725426 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/WebappRT.jsm
@@ +102,3 @@
>        return;
>      }
>  

Nit: you could return early here and avoid registering the timer altogether, but it doesn't really matter.
Attachment #8725426 - Flags: review?(mcastelluccio) → review+
Assignee

Comment 2

3 years ago
(In reply to Marco Castelluccio [:marco] from comment #1)
> Nit: you could return early here and avoid registering the timer altogether,

Indeed, this version does that.  It's the version I'll commit.

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/baabb61180e8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → Firefox Graveyard
Assignee

Updated

3 years ago
Depends on: 1258792
You need to log in before you can comment on or make changes to this bug.