Closed
Bug 1252635
Opened 7 years ago
Closed 7 years ago
don't check for updates unless mozApps is defined
Categories
(Firefox Graveyard :: Webapp Runtime, defect)
Firefox Graveyard
Webapp Runtime
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(2 files)
866 bytes,
patch
|
marco
:
review+
|
Details | Diff | Splinter Review |
919 bytes,
patch
|
Details | Diff | Splinter Review |
Without the mozApps API, it isn't possible to check for updates, so the runtime shouldn't try, or the attempt will throw an exception. That isn't the end of the world, but it could mislead someone looking at a log.
Attachment #8725426 -
Flags: review?(mcastelluccio)
Comment 1•7 years ago
|
||
Comment on attachment 8725426 [details] [diff] [review] confirm mozApps is defined before checking for updates Review of attachment 8725426 [details] [diff] [review]: ----------------------------------------------------------------- ::: webapprt/WebappRT.jsm @@ +102,3 @@ > return; > } > Nit: you could return early here and avoid registering the timer altogether, but it doesn't really matter.
Attachment #8725426 -
Flags: review?(mcastelluccio) → review+
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #1) > Nit: you could return early here and avoid registering the timer altogether, Indeed, this version does that. It's the version I'll commit.
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/baabb61180e8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•