1252635 - don't check for updates unless mozApps is defined

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: confirm mozApps is defined before checking for updates

Without the mozApps API, it isn't possible to check for updates, so the runtime shouldn't try, or the attempt will throw an exception.  That isn't the end of the world, but it could mislead someone looking at a log.

Comment 1

[Marco Castelluccio [:marco]]

Comment on attachment 8725426 [details] [diff] [review]
confirm mozApps is defined before checking for updates

Review of attachment 8725426 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/WebappRT.jsm
@@ +102,3 @@
>        return;
>      }
>  

Nit: you could return early here and avoid registering the timer altogether, but it doesn't really matter.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: confirm mozApps is defined before checking for updates

(In reply to Marco Castelluccio [:marco] from comment #1)
> Nit: you could return early here and avoid registering the timer altogether,

Indeed, this version does that.  It's the version I'll commit.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/baabb61180e8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/baabb61180e8