Closed Bug 1252635 Opened 4 years ago Closed 4 years ago

don't check for updates unless mozApps is defined

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(2 files)

Without the mozApps API, it isn't possible to check for updates, so the runtime shouldn't try, or the attempt will throw an exception.  That isn't the end of the world, but it could mislead someone looking at a log.
Attachment #8725426 - Flags: review?(mcastelluccio)
Comment on attachment 8725426 [details] [diff] [review]
confirm mozApps is defined before checking for updates

Review of attachment 8725426 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/WebappRT.jsm
@@ +102,3 @@
>        return;
>      }
>  

Nit: you could return early here and avoid registering the timer altogether, but it doesn't really matter.
Attachment #8725426 - Flags: review?(mcastelluccio) → review+
(In reply to Marco Castelluccio [:marco] from comment #1)
> Nit: you could return early here and avoid registering the timer altogether,

Indeed, this version does that.  It's the version I'll commit.
https://hg.mozilla.org/mozilla-central/rev/baabb61180e8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → Firefox Graveyard
Depends on: 1258792
You need to log in before you can comment on or make changes to this bug.