1252721 - Use Assert.jsm numeric comparison functions in PSM tests

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[:Cykesiopka]

This pattern can be seen in some PSM tests:
> Assert.ok(foo < bar, "foo should be less than bar");
> Assert.ok(foo > bar, "foo should be more than bar");

See https://hg.mozilla.org/mozilla-central/annotate/04db0fb529b9/security/manager/ssl/tests/unit/test_ocsp_timeout.js#l73 for an example.

Bug 1147751 added support for numeric comparison functions to Assert.jsm, so we should replace that sort of pattern with something like:
> Assert.less(foo, bar, "foo should be less than bar");
> Assert.greater(foo, bar, "foo should be more than bar");

See Bug 1147751 comment 0 for why the currently used pattern isn't as nice.

Comment 1

[Moritz Birghan [:mbirghan]]

Attachment: Bug 1252721 - Use Assert.jsm numeric comparison functions in PSM tests

Comment 2

[Phabricator Automation]

Comment on attachment 9082975 [details]
Bug 1252721 - Use Assert.jsm numeric comparison functions in PSM tests

Revision D40614 was moved to bug 1571656. Setting attachment 9082975 [details] to obsolete.