1252745 - Signed certificate timestamp extension doesn't work in TLS 1.3

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

This is largely because we were talked into accepting a dodgy memory management scheme for the extension data, but it is more than that.  The state is copied into the session (so that it is available after resumption), but that session isn't available in TLS <=1.2 until after the extension processing.

In TLS 1.3, this extension should be in EncryptedExtensions, which means that the session will be available.

Comment 1

[Martin Thomson [:mt:]]

The simplest fix would be to:

a) add this to KnownExtensions
b) in the client handler, copy the extension data over to the session if the version is TLS 1.3

That is, however, a disgusting option.

Comment 2

[Martin Thomson [:mt:]]

Review: https://nss-review.dev.mozaws.net/D50
Code: https://hg.mozilla.org/projects/nss/rev/467e55ab450c