Closed
Bug 1252750
Opened 8 years ago
Closed 8 years ago
Enable SpecialPowers to create nested event queue and spin it
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(4 files, 4 obsolete files)
|
1.28 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
1.16 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
2.31 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
2.05 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
There are a number of places in our testing code that either creates a syncXHR or uses a modal dialog to spin the event loop. We should create a helper API on special powers and convert the callers. patches incoming.
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → dougt
Attachment #8725543 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8725544 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8725545 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8725546 -
Flags: review?(mrbkap)
|
||
Updated•8 years ago
|
Attachment #8725543 -
Flags: review?(mrbkap) → review+
|
|
||
Updated•8 years ago
|
Attachment #8725544 -
Flags: review?(mrbkap) → review+
|
|
||
Updated•8 years ago
|
Attachment #8725545 -
Attachment is patch: true
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8725545 [details] [diff] [review] convert_test_media Review of attachment 8725545 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/tests/mochitest/test_getUserMedia_spinEventLoop.html @@ +15,5 @@ > return new Promise((resolve, reject) => { > navigator.mozGetUserMedia({ audio: true }, () => { > + SpecialPowers.spinEventLoop(window); > + ok(true, "Didn't crash"); > + resolve(); Nit: It looks like the existing code had some tabs in it. Please nuke them with prejudice.
Attachment #8725545 -
Flags: review?(mrbkap) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8725546 [details] [diff] [review] convert_test_webspeech Review of attachment 8725546 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8725546 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8725543 -
Attachment is obsolete: true
Attachment #8727044 -
Flags: review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Attachment #8725545 -
Attachment is obsolete: true
Attachment #8727045 -
Flags: review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
Attachment #8725544 -
Attachment is obsolete: true
Attachment #8727046 -
Flags: review+
|
|
Assignee | |
Comment 10•8 years ago
|
||
Attachment #8725546 -
Attachment is obsolete: true
Attachment #8727047 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a28f53a959 https://hg.mozilla.org/integration/mozilla-inbound/rev/398a0e720ccf https://hg.mozilla.org/integration/mozilla-inbound/rev/603aec801c48 https://hg.mozilla.org/integration/mozilla-inbound/rev/0148a8583cbc
Keywords: checkin-needed
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a9a28f53a959 https://hg.mozilla.org/mozilla-central/rev/398a0e720ccf https://hg.mozilla.org/mozilla-central/rev/603aec801c48 https://hg.mozilla.org/mozilla-central/rev/0148a8583cbc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•