Closed Bug 1252753 Opened 6 years ago Closed 6 years ago

Remove MediaDecoderStateMachine::PushFront()

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

DropAudioUpToSeekTarget() calls PushFront() at [1] but Push() at [2]. I think it should call Push() in both cases otherwise it would be confusing whether we should push the sample to the front or the back of the queue. This will also allow us to remove MediaDecoderStateMachine::PushFront().

[1] https://hg.mozilla.org/mozilla-central/file/a4929411c0aa3ec6b727e2bc2fc050c8199c6573/dom/media/MediaDecoderStateMachine.cpp#l2612
[2] https://hg.mozilla.org/mozilla-central/file/a4929411c0aa3ec6b727e2bc2fc050c8199c6573/dom/media/MediaDecoderStateMachine.cpp#l2572
Assignee: nobody → jwwang
Blocks: 1253184
Priority: -- → P2
Comment on attachment 8726637 [details]
MozReview Request: Bug 1252753. Part 1 - remove calls to PushFront(). r=kinetik.

https://reviewboard.mozilla.org/r/38131/#review35153
Attachment #8726637 - Flags: review?(kinetik) → review+
Attachment #8726638 - Flags: review?(kinetik) → review+
Comment on attachment 8726638 [details]
MozReview Request: Bug 1252753. Part 2 - remove MediaDecoderStateMachine::PushFront(). r=kinetik.

https://reviewboard.mozilla.org/r/38133/#review35155
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/4a4bb1aade86
https://hg.mozilla.org/mozilla-central/rev/d8886937457c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.