1252753 - Remove MediaDecoderStateMachine::PushFront()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

DropAudioUpToSeekTarget() calls PushFront() at [1] but Push() at [2]. I think it should call Push() in both cases otherwise it would be confusing whether we should push the sample to the front or the back of the queue. This will also allow us to remove MediaDecoderStateMachine::PushFront().

[1] https://hg.mozilla.org/mozilla-central/file/a4929411c0aa3ec6b727e2bc2fc050c8199c6573/dom/media/MediaDecoderStateMachine.cpp#l2612
[2] https://hg.mozilla.org/mozilla-central/file/a4929411c0aa3ec6b727e2bc2fc050c8199c6573/dom/media/MediaDecoderStateMachine.cpp#l2572

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd57efa9c824

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2806265c2f

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252753. Part 1 - remove calls to PushFront(). r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/38131/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38131/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252753. Part 2 - remove MediaDecoderStateMachine::PushFront(). r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/38133/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38133/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8726637 [details]
MozReview Request: Bug 1252753. Part 1 - remove calls to PushFront(). r=kinetik.

https://reviewboard.mozilla.org/r/38131/#review35153

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8726638 [details]
MozReview Request: Bug 1252753. Part 2 - remove MediaDecoderStateMachine::PushFront(). r=kinetik.

https://reviewboard.mozilla.org/r/38133/#review35155

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4bb1aade86
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8886937457c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a4bb1aade86
https://hg.mozilla.org/mozilla-central/rev/d8886937457c