Remove MediaDecoderStateMachine::mDecodeToSeekTarget

RESOLVED FIXED in Firefox 47

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
After fixing bug 1252762, mDecodeToSeekTarget is not used and can be removed.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Depends on: 1252762
AFAICT, it is currently used.

mDecodeToSeekTarget is used to determine if when state == DECODER_STATE_SEEKING and if so if we need to continue decoding until we reach the target.

It is set to false but MDSM::SeekComplete() may stay in DECODER_STATE_SEEKING if a new seek was started before the current one completing.

Can probably modify the logic so we don't we need, but the title of this bug indicates that it's not used, and right now it is.
(Assignee)

Comment 2

2 years ago
It won't after fixing bug 1252762. When writing patches for bug 1252762, it turned out mDecodeToSeekTarget is never read and can be removed safely.
(Assignee)

Updated

2 years ago
Blocks: 1253184
(Assignee)

Comment 3

2 years ago
Created attachment 8726553 [details]
MozReview Request: Bug 1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget which is never read. r=kaku.

Review commit: https://reviewboard.mozilla.org/r/38081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38081/
Attachment #8726553 - Flags: review?(tkuo)

Comment 4

2 years ago
Comment on attachment 8726553 [details]
MozReview Request: Bug 1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget which is never read. r=kaku.

https://reviewboard.mozilla.org/r/38081/#review34615
Attachment #8726553 - Flags: review?(tkuo) → review+
(Assignee)

Comment 5

2 years ago
Thanks!

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d994749000ad
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.