Closed Bug 1252766 Opened 5 years ago Closed 5 years ago

Remove MediaDecoderStateMachine::mDecodeToSeekTarget

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

After fixing bug 1252762, mDecodeToSeekTarget is not used and can be removed.
Assignee: nobody → jwwang
Depends on: 1252762
AFAICT, it is currently used.

mDecodeToSeekTarget is used to determine if when state == DECODER_STATE_SEEKING and if so if we need to continue decoding until we reach the target.

It is set to false but MDSM::SeekComplete() may stay in DECODER_STATE_SEEKING if a new seek was started before the current one completing.

Can probably modify the logic so we don't we need, but the title of this bug indicates that it's not used, and right now it is.
It won't after fixing bug 1252762. When writing patches for bug 1252762, it turned out mDecodeToSeekTarget is never read and can be removed safely.
Blocks: 1253184
Comment on attachment 8726553 [details]
MozReview Request: Bug 1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget which is never read. r=kaku.

https://reviewboard.mozilla.org/r/38081/#review34615
Attachment #8726553 - Flags: review?(tkuo) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/d994749000ad
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.