1252816 - Load the statusbar module only when making a phone build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Extract the statusbar module to a config file, loaded only when making a phone profile

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8725626 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master

Thoughts?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8725626 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master

Left a couple of comments on github, but no deal breakers. Looks like there is a failing unit test. We should probably just disable all those failing integration tests so that we can at least read these test runs.

In any case, feel free to land when you fix the unit test.

Comment 4

[Alberto Pastor [:albertopq]]

I guess we need to wait for the transition branch?

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Whoops, realized that you were just asking for feedback.

Overall, I love the idea and think the API looks simple enough. We definitely should land on the transition branch, I didn't realize that hadn't been created yet. I'll follow up with Gregor about it.

Go ahead and flag me for review when you're ready and we'll get moving on the transition branch.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8726211 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani

Fixed the tests and PR'd kanikani. r? Michael?

Thanks!

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8726211 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani

LGTM!

Comment 9

[Alberto Pastor [:albertopq]]

kanikani: https://github.com/mozilla-b2g/gaia/commit/ea16274011de8e0b387b6473439831faab32afc9