Load the statusbar module only when making a phone build

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: albertopq, Assigned: albertopq)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Extract the statusbar module to a config file, loaded only when making a phone profile
(Assignee)

Updated

2 years ago
Assignee: nobody → apastor

Comment 1

2 years ago
Created attachment 8725626 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8725626 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master

Thoughts?
Attachment #8725626 - Flags: feedback?(mhenretty)
Comment on attachment 8725626 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:master

Left a couple of comments on github, but no deal breakers. Looks like there is a failing unit test. We should probably just disable all those failing integration tests so that we can at least read these test runs.

In any case, feel free to land when you fix the unit test.
Attachment #8725626 - Flags: feedback?(mhenretty) → feedback+
(Assignee)

Comment 4

2 years ago
I guess we need to wait for the transition branch?
Whoops, realized that you were just asking for feedback.

Overall, I love the idea and think the API looks simple enough. We definitely should land on the transition branch, I didn't realize that hadn't been created yet. I'll follow up with Gregor about it.

Go ahead and flag me for review when you're ready and we'll get moving on the transition branch.

Comment 6

2 years ago
Created attachment 8726211 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani
(Assignee)

Comment 7

2 years ago
Comment on attachment 8726211 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani

Fixed the tests and PR'd kanikani. r? Michael?

Thanks!
Attachment #8726211 - Flags: review?(mhenretty)
Comment on attachment 8726211 [details] [review]
[gaia] albertopq:1252816-extract-statusbar > mozilla-b2g:kanikani

LGTM!
Attachment #8726211 - Flags: review?(mhenretty) → review+
(Assignee)

Comment 9

2 years ago
kanikani: https://github.com/mozilla-b2g/gaia/commit/ea16274011de8e0b387b6473439831faab32afc9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.