Upgrade loop-server's use of libsodium to 1.0.22

RESOLVED FIXED

Status

Hello (Loop)
Server
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I'd like to propose that we upgrade libsodium to 1.0.22. Using this allows me to npm install and run loop-server against node 0.12, as well as node 0.10. I haven't seen any issues yet.

Whilst we're probably not yet ready to upgrade the server version (and we're probably going to node 4, which I haven't tested at all yet). This is one more step in the right direction.
(Assignee)

Comment 1

2 years ago
Created attachment 8725645 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/367
Attachment #8725645 - Flags: review?(rhubscher)
Can you rebase with current master?
Attachment #8725645 - Flags: review?(rhubscher) → review+
https://github.com/mozilla-services/loop-server/commit/a1543ebc138f3878e10a9e9c918a5c88001f6d4f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

2 years ago
Thanks!
You need to log in before you can comment on or make changes to this bug.