Closed Bug 1252869 Opened 4 years ago Closed 4 years ago

Fix browser_experiments.js to work with e10s

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

defect

Tracking

(e10s+, firefox46 fixed, firefox47 fixed, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: gfritzsche, Assigned: Dexter)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file, 2 obsolete files)

e10s supposed to start shipping to some users on release with Firefox 46.

We need to fix the about:addons test for experiments for that:
toolkit/mozapps/extensions/test/browser/browser_experiments.js

Removing "skip-if = e10s" should be enough to reproduce failures.
Blocks: e10s-tests
tracking-e10s: --- → +
Priority: P2 → P1
Points: --- → 3
Assignee: nobody → alessio.placitelli
Comment on attachment 8727457 [details]
MozReview Request: Bug 1252869 - Fix browser_experiments.js to work with e10s. r?gfritzsche

https://reviewboard.mozilla.org/r/38481/#review35043

::: toolkit/mozapps/extensions/test/browser/browser_experiments.js:232
(Diff revision 1)
> +  yield BrowserTestUtils.synthesizeMouseAtCenter("#experiments-change-telemetry", {}, gBrowser.selectedBrowser);

Nit: That's a long line. Line-break after `{},` or use a short-hand for `BrowserTestUtils`.
Attachment #8727457 - Flags: review?(gfritzsche) → review+
Attachment #8727457 - Attachment is obsolete: true
Attachment #8727468 - Attachment is obsolete: true
Attached patch bug1252869.patchSplinter Review
I've carried over this patch (and the r+) from MozReview, as I messed up commit squashing there.

The related try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ca5446d5080

The relevant tests, M(bc2) and M-e10s(bc2), are green with no sign of errors.
Attachment #8727732 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/dddb62ccf997
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Target Milestone: Firefox 20 → Firefox 48
Comment on attachment 8727732 [details] [diff] [review]
bug1252869.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: None, this only add test coverage.
[Describe test coverage new/current, TreeHerder]: This test is currently skipped for e10s test runs. It landed on nightly a few days ago, with no sign of issues.
[Risks and why]: Low/no risk, limited to breaking e10s test coverage.
[String/UUID change made/needed]: None
Attachment #8727732 - Flags: approval-mozilla-beta?
Attachment #8727732 - Flags: approval-mozilla-aurora?
Comment on attachment 8727732 [details] [diff] [review]
bug1252869.patch

Adds new tests for e10s, please uplift
Attachment #8727732 - Flags: approval-mozilla-beta?
Attachment #8727732 - Flags: approval-mozilla-beta+
Attachment #8727732 - Flags: approval-mozilla-aurora?
Attachment #8727732 - Flags: approval-mozilla-aurora+
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.