Closed Bug 1252889 Opened 5 years ago Closed 5 years ago

On Windows use a 10 second pause instead of trying to invoke the JIT debugger with MOZ_DEBUG_CHILD_PROCESS

Categories

(Core :: General, defect)

All
Windows
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8725720 [details] [diff] [review]
On Windows use a 10 second pause instead of trying to invoke the JIT debugger with MOZ_DEBUG_CHILD_PROCESS

Review of attachment 8725720 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: toolkit/xre/nsEmbedFunctions.cpp
@@ +476,5 @@
>    nsQAppInstance::AddRef();
>  #endif
>  
>    if (PR_GetEnv("MOZ_DEBUG_CHILD_PROCESS")) {
> +      printf("\n\nCHILDCHILDCHILDCHILD\n  debug me @ %d\n\n",

nit - lets use printf_stderr.
Attachment #8725720 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/4ddd4d39a835
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
printf_stderr messages don't get print out to the console from the child process on Windows, so you can't actually see that the debugger stopped here. Why did we stop using the JIT debugger?
Flags: needinfo?(bobowen.code)
This was really quite useful - timed attach especially on a 10 second timer is a pain since you have to rush through menus to find the right plugin-container. Can we add this back and use a different env var for sleep?
Ah, right sorry, from speaking to a couple of people on the e10s team we'd found the JIT debugger a bit unreliable and we were doing this anyway generally, so thought we'd just make it permanent.

(In reply to Mason Chang [:mchang] from comment #5)
> printf_stderr messages don't get print out to the console from the child
> process on Windows, so you can't actually see that the debugger stopped
> here. Why did we stop using the JIT debugger?

Yes this is bug 1247959 and the things duped to it.
If you redirect to a file you should get the output.

(In reply to David Anderson [:dvander] from comment #6)
> This was really quite useful - timed attach especially on a 10 second timer
> is a pain since you have to rush through menus to find the right
> plugin-container. Can we add this back and use a different env var for sleep?

Yes, I'll sort this, apologies again.
Flags: needinfo?(bobowen.code)
Blocks: 1253850
You need to log in before you can comment on or make changes to this bug.