Closed Bug 1252959 Opened 10 years ago Closed 8 years ago

Add tooltip to lock icon in Task Inspector

Categories

(Taskcluster :: UI, defect)

Product:
Taskcluster
Component:
UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: akshitadvlp)

References

Details

(Keywords: good-first-bug)

It's really nice to have a lock icon that tells you that you need to log in to access certain artifacts, but it isn't obvious that that's what it means. It should have a tooltip that says something like "log in to access this". Except that's deceptive. Perhaps if you are logged out, it should say "you are not logged in", and if you are logged in with insufficient privileges, it should say "you do not have permission to access this" or something?
Keywords: good-first-bug
How about this: - put an icon on "public" artifacts and a different one on "private" artifacts - public tooltip: "This artifact is public and anyone can download it" - private tooltip: "This artifct is not public and requires scope `...` to download it"
Hello, I'm new to this, may I give this a go as a good-first-bug to tackle?
You can, but it's important to know that Cynthia is working on bug 1385307 which is very closely related, with a pull request in https://github.com/taskcluster/taskcluster-tools/pull/444. Once that lands, you could add the tooltips.
Assignee: nobody → akshitadvlp
Ohkay, then shall I wait for her to complete that issue?
Before making a PR, yes, but you can look at her PR and start thinking about how you would implement this while you wait.
can I get a little update on this bug.
Have a look at the pull request mentioned in comment 3.
Hello, I have started with this bug can I get a little description on the tooltip part.
The tooltips are described in comment 1. I'll be happy to answer any specific questions.
I understood the changes made in relation with the artifacts, But I am facing the problem of understanding where the changes made at PR #444 (src/components/ArtifactList/index.js) are reflected and how should I proceed.
Cynthia's changes added a new icon (<i className="fa fa-lock" ../>) to the artifact list. This bug involves adding a tooltip to that icon saying "This artifact is not public..".
Thank you, for your guidance.
Hello, I am almost done with the code, Just needed to ask about the scope assigned to the user. If an artifact is private, should I display the scope of the user to see the artifact or just the message that it is private. Thanks
I think a message saying this it is private is sufficient.
I have done the code and made PR #486.
Hello, Can I get reviews on the changes:)
I typically do my reviews daily, and we don't do them instantly, so I will take a look at this tomorrow. Thanks!
Ohkay, Thank you, I was actually excited about the changes. sorry for the inconvenience.
No worries, and no inconvenience! Just wanted to be clear and realistic about when I could get to this. Thank you for understanding!
Hello, I have made the changes and updated the PR#486
@Eli perelman, Do I need to make any further updation in the PR#486? :)
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools https://github.com/taskcluster/taskcluster-tools/commit/8887d9ffcd33d4146ece44a9610860cf72d95654 Bug 1252959: Add tooltip to lock icon in Task Inspector (#486) * Bug 1252959 Fixed * Revert "Bug 1252959 Fixed" This reverts commit 5ad9ab5e20988bf09eaf8e5952bc7d3a6558c152. * Revert "Bug 1252959 Fixed" This reverts commit 58fa337847970824708b085def97e94f37e3af65. * Update * update the naming
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Tools → UI and Tools
You need to log in before you can comment on or make changes to this bug.