Offer |mach artifact| builds in |mach bootstrap| for Firefox for Desktop

RESOLVED FIXED in Firefox 51

Status

defect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: sambuddhabasu1, Assigned: timdream, Mentored)

Tracking

(Depends on 1 bug)

unspecified
mozilla51
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822
Presently, in |mach bootstrap|, for non-Fennec builds, only "Firefox for Desktop" is available. We want to extend this to add |mach artifact| builds so that we have a "Firefox for Desktop Artifact Mode" option.
Mentor: nalexander
Attachment #8725828 - Flags: review?(nalexander)
Comment on attachment 8725828 [details]
MozReview Request: Bug 1252976 - Offer |mach artifact| builds in |mach bootstrap| for non-Fennec builds r=nalexander

https://reviewboard.mozilla.org/r/37661/#review35141

This is a good first step, but it doesn't actually stop installing the (large, expensive to fetch) toolchains that aren't needed for artifact builds.  I'd like to see this either add an `artifact_mode` flag, or really add `ensure_..._artifact_mode` functions in the relevant places.  In addition, comment in each bootstrap implementation that this doesn't actually install the minimum set of things for artifact builds, so that future people know where to improve your work.

Thanks!
Sambuddha, are you still working on this? Would you mind if I steal your patch and take it to the finish line?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(sambuddhabasu1)
Comment on attachment 8778817 [details]
Bug 1252976 - Offer |mach artifact| builds in |mach bootstrap| for non-Fennec builds

https://reviewboard.mozilla.org/r/69972/#review67120

This review request simply rebase Sambuddha's commit and add artifact_mode flag to places as asked in the last review.

We could decide to land this as-is, or actually try not to download some toolchains. For the latter I would need some better ideas and I might not be able to figure this out for all OSes...
Attachment #8725828 - Attachment is obsolete: true
Comment on attachment 8778827 [details]
Bug 1252976 - Follow up, Update Note on Artifact Mode,

https://reviewboard.mozilla.org/r/69976/#review67204
Attachment #8778827 - Flags: review?(nalexander) → review+
Comment on attachment 8778817 [details]
Bug 1252976 - Offer |mach artifact| builds in |mach bootstrap| for non-Fennec builds

https://reviewboard.mozilla.org/r/69974/#review67206
Attachment #8778817 - Flags: review?(nalexander) → review+
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(sambuddhabasu1)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcad237aa05
Offer |mach artifact| builds in |mach bootstrap| for non-Fennec builds r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6af03871248e
Follow up, Update Note on Artifact Mode, r=nalexander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dbcad237aa05
https://hg.mozilla.org/mozilla-central/rev/6af03871248e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.