125298 - [Mac OS X]Fonts are not displayed properly in preferences

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Yuying Long]

Build: 02-13 trunk build on Mac OS X

Steps:
1. Launch browser and go to Edit | Preferences | Appearance | Fonts.
2. Select fonts for Japanese.

Result:
You will see some non-Japanese fonts are listed there, and they are not
displayed properly - See a screen shot later.

Comment 1

[Yuying Long]

Attachment: screen shot for the Japanese fonts in preferences.

Comment 2

[Yuying Long]

I checked it existing on N6.2.1 also.

I just remember I added the Hebrew fonts/IME last month, and by the time we
tested N6.2.1, I didn't have Hebrew in my machine that's why I haven't seen it
before.

Btw, I'm using Mac OS 10.1-JA.

On Mac OS 9.1-JA, I don't see this problem even I have Hebrew installed.

Comment 3

[Roy Yokoyama]

->over to MacOSX i18n guru

Comment 4

[Frank Tang]

nsbeta1+ per triage meeting
give to ftang
ylong say this is happening on MacOS X 10.1.2

Comment 5

[Frank Tang]

we have two issue here
issue 1. we display ? mark for hebrew and arabic font
issue 2. Hebrew font list under the encoding of the locale (so hebrew font list
under Japanese if the locale is set to japanese)

I will solve issue 1 in this bug and issue 2 with bug 95978

Comment 6

[Frank Tang]

Attachment: patch that do not display ? for control characers

This is a well known problem in Bidi Mac. Somehow TEC add control characters
that we cannot display when convert " " in Arabic and Hebrew encoding. We
simply do not display ? for control character here. We may want to add more
control characters here.

Comment 7

[nhottanscp]

>We may want to add more control characters here. 

The patch checks two characters.
\u202C - POP DIRECTIONAL FORMATTING
\u202D - LEFT-TO-RIGHT OVERRIDE

I found those. Should those also be checked?
\u202A - LEFT-TO-RIGHT-EMBEDDING
\u202B - RIGHT-TO-LEFT EMBEDDING
\u202E - RIGHT-TO-LEFT OVERRIDE

Comment 8

[Frank Tang]

Attachment: v2 patch

Comment 9

[nhottanscp]

Comment on attachment 73098 [details] [diff] [review]
v2 patch

r=nhotta

There are multiple of
if(! fallbackDone) in different #ifdef. I think that has to change in future
for readability.

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 73098 [details] [diff] [review]
v2 patch

sr=sfraser

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 73098 [details] [diff] [review]
v2 patch

a=roc+moz

Comment 12

[Frank Tang]

fixed and check in the ? part. The "which font should be list here" issue is in
other bugs. 

Comment 13

[Frank Tang]

the issue 2 is now in bug 130443 instead of bug 95978

Comment 14

[Yuying Long]

The original problem is not existing on 03-18 trunk build/Mac 10.1.3.

Mark as verified.