Closed Bug 1253057 Opened 5 years ago Closed 5 years ago

Instrument PGO "tier" times

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

As part of measuring PGO times on Windows, I realized our build system monitor doesn't do a good job of reporting how much time is spent in which PGO "tiers." Let's add some more explicit reporting.
This will enable each PGO phase to show up in mach's resource reporting,
making it easier to compare PGO runtime across machines. This does
confuse the rendering of `mach resource-usage` a bit since it doesn't
know how to handle overlapping tiers. But the raw data is captured as
expected. I don't think `mach resource-usage` is that heavily used right
now, so I don't care about a minor regression for PGO builds.

Review commit: https://reviewboard.mozilla.org/r/37691/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37691/
Attachment #8725924 - Flags: review?(ted)
Comment on attachment 8725924 [details]
MozReview Request: Bug 1253057 - Record PGO phases as build tiers; r?ted

https://reviewboard.mozilla.org/r/37691/#review34381

::: client.mk:238
(Diff revision 1)
> +	$(call BUILDSTATUS,TIERS pgo_instrument pgo_package pgo_profile pgo_clobber pgo_update)

Can we call the first/last tiers pgo_profile_generate and pgo_profile_use to match the `MOZ_PROFILE_{GENERATE,USE}` variables?
Attachment #8725924 - Flags: review?(ted) → review+
https://reviewboard.mozilla.org/r/37691/#review34381

> Can we call the first/last tiers pgo_profile_generate and pgo_profile_use to match the `MOZ_PROFILE_{GENERATE,USE}` variables?

Good idea. I'll update these then land.
Comment on attachment 8725924 [details]
MozReview Request: Bug 1253057 - Record PGO phases as build tiers; r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37691/diff/1-2/
https://hg.mozilla.org/mozilla-central/rev/570ffd010895
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.