1253109 - Bugzilla API key URLs incorrect

Status: RESOLVED FIXED

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Gregory Szorc [:gps]]

A few places in version-control-tools we are advertising https://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/install.html#bugzilla-credentials. This anchor no longer exists and the URL should be updated.

Comment 1

[Mark Côté [:mcote]]

Looks like the new URL should probably be http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges in all cases.

Comment 2

[Mark Côté [:mcote]]

Attachment: MozReview Request: hgext: Update reference to docs on MozReview credentials (bug 1253109); r?gps

Review commit: https://reviewboard.mozilla.org/r/50293/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50293/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8748445 [details]
MozReview Request: hgext: Update reference to docs on MozReview credentials (bug 1253109); r?gps

https://reviewboard.mozilla.org/r/50293/#review47275

::: hgext/reviewboard/hgrb/proto.py:26
(Diff revision 1)
>  from hgrb.util import ReviewID
>  
>  
>  API_KEY_NEEDED = (
>      'Bugzilla API keys are now used by MozReview; '
> -    'see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials '
> +    'see http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges '

You dropped https://

::: hgext/reviewboard/hgrb/proto.py:208
(Diff revision 1)
>      bzusername = req.get('bzusername')
>      bzapikey = req.get('bzapikey')
>  
>      if not bzusername or not bzapikey:
>          return errorresponse('Bugzilla API keys not configured; see '
> -            'https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials '
> +            'http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges '

Ditto.

::: hgext/reviewboard/tests/test-auth.t:40
(Diff revision 1)
>    $ hg --config bugzilla.userid=baduserid --config bugzilla.cookie=irrelevant --config bugzilla.apikey= push
>    pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
>    searching for changes
>    no changes found
>    submitting 1 changesets for review
> -  abort: Bugzilla API keys not configured; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
> +  abort: Bugzilla API keys not configured; see http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client

Ditto.

::: hgext/reviewboard/tests/test-auth.t:50
(Diff revision 1)
>    $ hg --config bugzilla.username=unknown --config bugzilla.apikey=irrelevant push
>    pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
>    searching for changes
>    no changes found
>    submitting 1 changesets for review
> -  abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
> +  abort: Bugzilla API keys are now used by MozReview; see http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client

Ditto.

::: hgext/reviewboard/tests/test-auth.t:65
(Diff revision 1)
>    $ hg --config bugzilla.username=[e-mail] --config bugzilla.apikey=badkey push
>    pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
>    searching for changes
>    no changes found
>    submitting 1 changesets for review
> -  abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
> +  abort: Bugzilla API keys are now used by MozReview; see http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client

Ditto.

Comment 4

[Mark Côté [:mcote]]

https://reviewboard.mozilla.org/r/50293/#review47275

> You dropped https://

Good catch, thanks!

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8748445 [details]
MozReview Request: hgext: Update reference to docs on MozReview credentials (bug 1253109); r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50293/diff/1-2/

Comment 6

[Mark Côté [:mcote]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/41419e3f0fe2