1253120 - Allow UITour's showFirefoxAccounts command to allow non alphanumeric strings for param values

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-XXXXXXX-drop-the-restriction-on-param-values-pas.patch

It turns out that the restriction on param values we introduced in bug 1244929 is too restrictive, and given the code will auto-encode values, there's no good reason to keep that restriction.

This patch keeps the existing restriction in param names, but allows any characters in the param values. The test ensures these values are encoded in the final URL.

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 8725996 [details] [diff] [review]
0001-Bug-XXXXXXX-drop-the-restriction-on-param-values-pas.patch

Review of attachment 8725996 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about causing the churn by making this extra strict. I hadn't seen paths used in the utm parameters before

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2eb7b3fd4cc0

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2eb7b3fd4cc0

Comment 4

[Jonathan Petto [:jpetto]]

Just a note that the comment in UITour-lib.js [1] still states that values must be alphanumeric. Probably good to clean that up to avoid future confusion. :)

(Please ignore if this is already done/underway and just not yet reflected.)

[1] https://dxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour-lib.js#240

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Thanks, I just pushed a followup

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8b57efc13045

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b57efc13045

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a83cd998213e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a83cd998213e