Closed Bug 1253130 Opened 4 years ago Closed 4 years ago

Support alwaysOnTop in the browser.windows API

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [windows][berlin][good first bug])

Attachments

(1 file)

This is equivalent to our "alwaysRaised" window feature.
Whiteboard: [windows][berlin] → [windows][berlin][good first bug]
Assignee: nobody → kmaglione+bmo
Summary: Support alwaysOnTop in the browser.windows.create → Support alwaysOnTop in the browser.windows API
Comment on attachment 8731749 [details]
MozReview Request: Bug 1253130: [webext] Support the `alwaysOnTop` in the browser.windows API. r?gabor

https://reviewboard.mozilla.org/r/40815/#review37787

::: browser/components/extensions/ext-utils.js:756
(Diff revision 1)
>        width: window.outerWidth,
>        height: window.outerHeight,
>        incognito: PrivateBrowsingUtils.isWindowPrivate(window),
>        type: this.windowType(window),
>        state,
> +      alwaysOnTop: xulWindow.zLevel >= xulWindow.raisedZ,

Can we use nsIXULWindow::raisedZ instead? I think then it's more obvius that this property is a constant on the interface and not an actual property on the xulWindow instance.
Attachment #8731749 - Flags: review?(gkrizsanits) → review+
https://reviewboard.mozilla.org/r/40815/#review37787

> Can we use nsIXULWindow::raisedZ instead? I think then it's more obvius that this property is a constant on the interface and not an actual property on the xulWindow instance.

Yeah, that's a good point. I don't know why those properties have names that don't look like constants. It's a bit strange.
https://hg.mozilla.org/integration/fx-team/rev/1f4e567893feb5e288621c50d58e99232a141c48
Bug 1253130: [webext] Support the `alwaysOnTop` in the browser.windows API. r=gabor
https://hg.mozilla.org/mozilla-central/rev/1f4e567893fe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.