1253132 - Support window states in the browser.windows API

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Kris Maglione [:kmag]]

Chrome supports "normal", "minimized", "maximized", "fullscreen", and "docked". This bug covers the first four. The last may have to be handled in a follow-up.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1253132: [webext] Support window states in browser.windows APIs. r?billm

Review commit: https://reviewboard.mozilla.org/r/38071/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38071/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8726511 [details]
MozReview Request: Bug 1253132: [webext] Support window states in browser.windows APIs. r?billm

https://reviewboard.mozilla.org/r/38071/#review34829

::: browser/components/extensions/ext-utils.js:688
(Diff revision 1)
> +    if (window.fullScreen) {
> +      state = "fullscreen";
> +    }

It looks like there's a STATE_FULLSCREEN too. Does that work?

::: browser/components/extensions/ext-windows.js:144
(Diff revision 1)
> +              window.document.documentElement.setAttribute("sizemode", createData.state);

I guess I don't know much about XUL window sizing. Why use this sizemode thing here and use WindowManager.setState (which calls .maximize, etc.) elsewhere?

Comment 3

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/38071/#review34829

> It looks like there's a STATE_FULLSCREEN too. Does that work?

Nope. It returns MAXIMIZED when in fullscreen mode. I'm not sure if the constant is left-over, or if it's actually used somewhere, but it's not used here.

> I guess I don't know much about XUL window sizing. Why use this sizemode thing here and use WindowManager.setState (which calls .maximize, etc.) elsewhere?

Setting the attribute only works before the window is shown. Calling the methods only works after. I considered just waiting for the window to be shown, and then calling setState in all cases, but I don't like the idea of having the window show in one state, and then immediately resizing.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

OK, sounds good.

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/2e3b78d27f7b0d036d29435d7bb2241947823bb5
Bug 1253132: [webext] Support window states in browser.windows APIs. r=billm

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e3b78d27f7b