Closed
Bug 1253134
Opened 8 years ago
Closed 8 years ago
Support drawAttention in browser.windows.update
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: kmag, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
(Whiteboard: [windows][berlin][good first bug])
Attachments
(1 file)
3.63 KB,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•8 years ago
|
Iteration: --- → 47.3 - Mar 7
Reporter | ||
Updated•8 years ago
|
Assignee: kmaglione+bmo → nobody
Whiteboard: [windows] → [windows][berlin]
Reporter | ||
Updated•8 years ago
|
Iteration: 47.3 - Mar 7 → ---
Reporter | ||
Updated•8 years ago
|
Whiteboard: [windows][berlin] → [windows][berlin][good first bug]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → evilpies
Assignee | ||
Comment 1•8 years ago
|
||
I don't think we can actually test if this is actually working. There seems to be no API to tell if a window is flashing.
Attachment #8731246 -
Flags: review?(kmaglione+bmo)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8731246 [details] [diff] [review] Implement browser.windows.update - drawAttention Review of attachment 8731246 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/extensions/ext-windows.js @@ +193,5 @@ > WindowManager.setState(window, updateInfo.state); > } > > + if (updateInfo.drawAttention) { > + // Firefox can't cancel attention actions. Can you file a follow-up bug to add support?
Attachment #8731246 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Filed bug 1257497.
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/31c825f90fc8 https://hg.mozilla.org/mozilla-central/rev/b2696e01cbae
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•