Closed Bug 1253134 Opened 4 years ago Closed 4 years ago

Support drawAttention in browser.windows.update

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: kmag, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [windows][berlin][good first bug])

Attachments

(1 file)

No description provided.
Iteration: --- → 47.3 - Mar 7
Assignee: kmaglione+bmo → nobody
Whiteboard: [windows] → [windows][berlin]
Iteration: 47.3 - Mar 7 → ---
Whiteboard: [windows][berlin] → [windows][berlin][good first bug]
Assignee: nobody → evilpies
I don't think we can actually test if this is actually working. There seems to be no API to tell if a window is flashing.
Attachment #8731246 - Flags: review?(kmaglione+bmo)
Comment on attachment 8731246 [details] [diff] [review]
Implement browser.windows.update - drawAttention

Review of attachment 8731246 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/extensions/ext-windows.js
@@ +193,5 @@
>            WindowManager.setState(window, updateInfo.state);
>          }
>  
> +        if (updateInfo.drawAttention) {
> +          // Firefox can't cancel attention actions.

Can you file a follow-up bug to add support?
Attachment #8731246 - Flags: review?(kmaglione+bmo) → review+
Filed bug 1257497.
https://hg.mozilla.org/mozilla-central/rev/31c825f90fc8
https://hg.mozilla.org/mozilla-central/rev/b2696e01cbae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.