1253134 - Support drawAttention in browser.windows.update

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Implement browser.windows.update - drawAttention

I don't think we can actually test if this is actually working. There seems to be no API to tell if a window is flashing.

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8731246 [details] [diff] [review]
Implement browser.windows.update - drawAttention

Review of attachment 8731246 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/extensions/ext-windows.js
@@ +193,5 @@
>            WindowManager.setState(window, updateInfo.state);
>          }
>  
> +        if (updateInfo.drawAttention) {
> +          // Firefox can't cancel attention actions.

Can you file a follow-up bug to add support?

Comment 3

[Tom S. (please needinfo tschuster)]

Filed bug 1257497.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31c825f90fc8

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2696e01cbae

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/31c825f90fc8
https://hg.mozilla.org/mozilla-central/rev/b2696e01cbae