Cleanup running extensions after test failures

RESOLVED FIXED in Firefox 47

Status

RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

unspecified
mozilla47

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently, a timeout or exception which prevents a test from unloading an extension causes the rest of the tests in the group to fail with "Error: unable to handle multiple listeners for SPExtensionMessage". We should handle this more gracefully, probably by registering a cleanup function to shutdown any extensions which are still running when the test ends.
(Assignee)

Comment 1

3 years ago
Created attachment 8726061 [details]
MozReview Request: Bug 1253148: [webext] Cleanup running extensions on test failure. r?billm

Review commit: https://reviewboard.mozilla.org/r/37789/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37789/
Attachment #8726061 - Flags: review?(wmccloskey)
Comment on attachment 8726061 [details]
MozReview Request: Bug 1253148: [webext] Cleanup running extensions on test failure. r?billm

https://reviewboard.mozilla.org/r/37789/#review34529
Attachment #8726061 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/cd697b51aed416ac3be564b7b2dff6b44178481b
Bug 1253148: [webext] Cleanup running extensions on test failure. r=billm

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cd697b51aed4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

8 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.