Replace reminder macros in libssl

RESOLVED FIXED in 3.28

Status

NSS
Libraries
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mt, Assigned: mt)

Tracking

Firefox Tracking Flags

(firefox47 affected)

Details

(Assignee)

Description

2 years ago
These macros need auditing for correctness.  They all indicate potential bugs; or wooly code.

#define SET_ERROR_CODE    /* reminder */
#define SEND_ALERT        /* reminder */
#define TEST_FOR_FAILURE  /* reminder */
#define DEAL_WITH_FAILURE /* reminder */
(Assignee)

Comment 1

2 years ago
Tim, see http://codereview.appspot.com/291500043
Flags: needinfo?(ttaubert)
(Assignee)

Comment 2

2 years ago
I'm going to come back to this once my big DHE patch is done.  The two will conflict and this isn't important.
Flags: needinfo?(ttaubert)
(Assignee)

Updated

2 years ago
Assignee: nobody → martin.thomson
(Assignee)

Comment 3

2 years ago
Updated review link: https://codereview.appspot.com/307290043
(Assignee)

Comment 4

a year ago
I'd like to land this one some time.
Flags: needinfo?(ttaubert)
Sorry, closed this tab somehow :/ Will review ASAP.
Flags: needinfo?(ttaubert)
Flags: needinfo?(ttaubert)
LGTM
Flags: needinfo?(ttaubert)
(Assignee)

Comment 7

a year ago
https://hg.mozilla.org/projects/nss/rev/4553276f3873
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → 3.28
You need to log in before you can comment on or make changes to this bug.