1253181 - [Presentation API] fix the code of calling not existing listener call.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Fix the variable name in TCPPresentationServer.js

TCPPresentationServer is using the not exist listener call as follow.

|listener._onOffer| [1] 
|listener._onAnswer| [2]

Perhaps, I think we should remove '_listener' object.
Is it right?

[1] https://dxr.mozilla.org/mozilla-central/rev/c59c022943f6a7e79f6002e11fc9f56cb836f5dd/dom/presentation/provider/TCPPresentationServer.js#583
[2] https://dxr.mozilla.org/mozilla-central/rev/c59c022943f6a7e79f6002e11fc9f56cb836f5dd/dom/presentation/provider/TCPPresentationServer.js#591

And perhaps type in onSessionRequest[3]. I think it should require '_' prefix before 'listener'.
[3] https://dxr.mozilla.org/mozilla-central/rev/c59c022943f6a7e79f6002e11fc9f56cb836f5dd/dom/presentation/provider/TCPPresentationServer.js#152

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8726109 [details] [diff] [review]
Fix the variable name in TCPPresentationServer.js

Review of attachment 8726109 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/presentation/provider/TCPPresentationServer.js
@@ +148,5 @@
>    // Triggered by TCPControlChannel
>    onSessionRequest: function(aDeviceInfo, aUrl, aPresentationId, aControlChannel) {
>      DEBUG && log("TCPPresentationServer - onSessionRequest: "
>                   + aDeviceInfo.address + ":" + aDeviceInfo.port);
> +    this._listener.onSessionRequest(aDeviceInfo,

the original code is correct because we have a "get listener" function.

@@ +579,5 @@
>      if (this._pendingOffer) {
>        let offer = this._pendingOffer;
>        DEBUG && log("TCPControlChannel - notify pending offer: "
>                     + JSON.stringify(offer));
> +      this._onOffer(new ChannelDescription(offer));

correct fix should be this._listener.onOffer(new ChannelDescription(offer));

@@ +587,5 @@
>      if (this._pendingAnswer) {
>        let answer = this._pendingAnswer;
>        DEBUG && log("TCPControlChannel - notify pending answer: "
>                     + JSON.stringify(answer));
> +      this._onAnswer(new ChannelDescription(answer));

this._listener.onAnswer(new ChannelDescription(answer));

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f07cb8b2bcd3

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Fix the variable name in TCPPresentationServer.js

Thanks schien.

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #1)
> the original code is correct because we have a "get listener" function.
Oh, I misunderstood those implementation.

> @@ +579,5 @@
> correct fix should be this._listener.onOffer(new ChannelDescription(offer));
OK. I fixed. and I'll create xpsshell test of TCPPresentationServer at other new bug.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ea4c89d09c9

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8726230 [details] [diff] [review]
Fix the variable name in TCPPresentationServer.js

Review of attachment 8726230 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2e521cbd13

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e2e521cbd13