1253188 - [TV][2.5] The context menu still shows "Add to Apps" even the marketplace content has been added

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Luke Chang [:lchang] (inactive)]

STR:

1. launch "Web Apps"
2. focus on the "kicker" icon
3. press ENTER key to preview it
4. press OPTION key and choose "Add to Apps"
5. press BACK key to return to "Web Apps"
6. press OPTION key to trigger the context menu
7. the context menu still shows "Add to Apps" incorrectly

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1253188_tv_normalize_preview_url > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8726133 [details] [review]
[gaia] luke-chang:1253188_tv_normalize_preview_url > mozilla-b2g:master

This bug happens because the preview URL passed through "window.open" API [1] will be normalized automatically by Gecko. That is, the same URL coming from "window.open" and the label of the context menu [2] may result in different strings.

So, in this patch, I used "new URL().toString()" to normalize the URL string manually when receiving it from the label.

Hi Rex, could you take a look? Thanks.


[1] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/wrapper_factory.js#L46
[2] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/browser_context_menu.js#L309

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8726133 [details] [review]
[gaia] luke-chang:1253188_tv_normalize_preview_url > mozilla-b2g:master

Looks good. thanks!

Comment 4

[Luke Chang [:lchang] (inactive)]

Rex, thanks!

landed on master: https://github.com/mozilla-b2g/gaia/commit/5c7fd377892b724783cd2339538d301a1c84a7d4

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8726133 [details] [review]
[gaia] luke-chang:1253188_tv_normalize_preview_url > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature.
[User impact] if declined: feature wouldn't be complete.
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): low.
[String changes made]: n/a

Comment 6

[cindylee]

This issue is verified on following build.
[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5c7fd377892b724783cd2339538d301a1c84a7d4
gecko:
https://hg.mozilla.org/mozilla-central/rev/a75d87f4cf527815e6271932676800138c27da70

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8726133 [details] [review]
[gaia] luke-chang:1253188_tv_normalize_preview_url > mozilla-b2g:master

Approve for TV 2.5

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1253188_tv_v2.5_normalize_preview_url > mozilla-b2g:v2.5

Comment 9

[Luke Chang [:lchang] (inactive)]

landed on v2.5: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638

Comment 10

[cindylee]

This issue is verified on v2.5 latest build.

[Build Info]
gaia:
https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3