Closed Bug 1253189 Opened 4 years ago Closed 4 years ago

Import reftests of CSS Values and Units from CSSWG

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Comment on attachment 8726142 [details]
MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37827/diff/1-2/
Comment on attachment 8726143 [details]
MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37829/diff/1-2/
Comment on attachment 8726144 [details]
MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37831/diff/1-2/
Comment on attachment 8726145 [details]
MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37833/diff/1-2/
Comment on attachment 8726146 [details]
MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37835/diff/1-2/
Comment on attachment 8726142 [details]
MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37827/diff/2-3/
Comment on attachment 8726143 [details]
MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37829/diff/2-3/
Comment on attachment 8726144 [details]
MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37831/diff/2-3/
Comment on attachment 8726145 [details]
MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37833/diff/2-3/
Attachment #8726145 - Attachment description: MozReview Request: But 1253189 part 4 - Add skip.list for skipping imported tests. → MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests.
Comment on attachment 8726146 [details]
MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37835/diff/2-3/
Comment on attachment 8726142 [details]
MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. r=dbaron

https://reviewboard.mozilla.org/r/37827/#review34971

I guess there isn't a nice way to do this with python os.path...
Attachment #8726142 - Flags: review?(dbaron) → review+
Comment on attachment 8726143 [details]
MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. r=dbaron

https://reviewboard.mozilla.org/r/37829/#review34973

::: layout/reftests/w3c-css/import-tests.py:214
(Diff revision 3)
> -        raise StandardError("Could not associate test with specification")
> +        raise StandardError("Could not associate test " + fn + " with specification")

probably preferable to do:

"Could not associate test {0} with specification".format(fn)
Attachment #8726143 - Flags: review?(dbaron) → review+
Comment on attachment 8726144 [details]
MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. r=dbaron

https://reviewboard.mozilla.org/r/37831/#review34975
Attachment #8726144 - Flags: review?(dbaron) → review+
Comment on attachment 8726145 [details]
MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. r=dbaron

https://reviewboard.mozilla.org/r/37833/#review34977
Attachment #8726145 - Flags: review?(dbaron) → review+
Comment on attachment 8726146 [details]
MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. r=dbaron

https://reviewboard.mozilla.org/r/37835/#review34979

::: layout/reftests/moz.build:280
(Diff revision 3)
> +with Files('w3c-css/received/css3-values/**'):
> +    BUG_COMPONENT = ('Core', 'CSS Parsing and Computation')
>  with Files('w3c-css/received/css-namespaces-3/**'):
>      BUG_COMPONENT = ('Core', 'CSS Parsing and Computation')
> +with Files('w3c-css/received/css-values-3/**'):
> +    BUG_COMPONENT = ('Core', 'CSS Parsing and Computation')

It would probably be better to have code in import-tests.py to canonicalize the spec name to one name or the other (probably css-values-3) rather than having two subdirectories?

::: layout/reftests/w3c-css/failures.list:9
(Diff revision 3)
> +css3-values/attr-color-invalid-cast.html
> +css3-values/attr-color-valid.html
> +css3-values/attr-length-invalid-cast.html
> +css3-values/attr-length-valid-zero-nofallback.html
> +css3-values/attr-length-valid-zero.html
> +css3-values/attr-length-valid.html
> +css3-values/attr-px-invalid-cast.html
> +css3-values/attr-px-valid.html
> +css3-values/calc-in-calc.html
> +css3-values/calc-in-media-queries-001.html
> +css3-values/calc-in-media-queries-002.html
> +css3-values/vh-interpolate-pct.html

could you annotate bug numbers here?  I think most, if not all, should have existing bugs.

::: layout/reftests/w3c-css/skip.list:17
(Diff revision 3)
> +# because of support files (in iframe subdir) not being copied
> +css3-values/vh-support-transform-origin.html
> +css3-values/vh-support-transform-translate.html

Maybe worth at least filing a followup bug on this (and noting the bug number in the comment)?
Attachment #8726146 - Flags: review?(dbaron) → review+
https://reviewboard.mozilla.org/r/37835/#review34979

> It would probably be better to have code in import-tests.py to canonicalize the spec name to one name or the other (probably css-values-3) rather than having two subdirectories?

Probably we should rely on the directory name rather than the spec url in the test file? Or probably make gSubtrees store {spec: path} rather than just [path]?
https://reviewboard.mozilla.org/r/37835/#review34979

> Probably we should rely on the directory name rather than the spec url in the test file? Or probably make gSubtrees store {spec: path} rather than just [path]?

Either sounds fine.
Blocks: 1256580
Comment on attachment 8726142 [details]
MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37827/diff/3-4/
Attachment #8726142 - Attachment description: MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. → MozReview Request: Bug 1253189 part 1 - Make import-tests.py compatible with Windows. r=dbaron
Comment on attachment 8726143 [details]
MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37829/diff/3-4/
Attachment #8726143 - Attachment description: MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. → MozReview Request: Bug 1253189 part 2 - Update import-tests.py script to work on the current repo. r=dbaron
Comment on attachment 8726144 [details]
MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37831/diff/3-4/
Attachment #8726144 - Attachment description: MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. → MozReview Request: Bug 1253189 part 3 - Update existing received w3c reftests. r=dbaron
Comment on attachment 8726145 [details]
MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37833/diff/3-4/
Attachment #8726145 - Attachment description: MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. → MozReview Request: Bug 1253189 part 4 - Add skip.list for skipping imported tests. r=dbaron
Comment on attachment 8726146 [details]
MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37835/diff/3-4/
Attachment #8726146 - Attachment description: MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. → MozReview Request: Bug 1253189 part 5 - Import reftests of css-values. r=dbaron
https://hg.mozilla.org/integration/mozilla-inbound/rev/333350cd3e3fd8d73d4d335b268004a0fa761132
Bug 1253189 followup - Update skip.list to match the directory name on CLOSED TREE
Assignee: nobody → quanxunzhen
You need to log in before you can comment on or make changes to this bug.