1253221 - Sync changes from GCLI web project with GCLI in mozilla-central (part 1)

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[Joe Walker [:jwalker]]

The merge between the 2 projects isn't too complex, but I'll do it in steps.

Changes in this patch:

* GCLI gave up with testing via phantomjs a while ago, but the docs didn't keep
  up, so this fixes the docs.

* gcli/languages/command isn't used in Firefox, but on the web if a converter
  wrongly produces a null DOM node, then the UI just looks blank, so this change
  makes the error more obvious. However we don't use this in Firefox. I'd like to
  remove the module, but not in this patch.

* The delegate type (used when we want to defer the type of a parameter, e.g.
  with "pref set PREFNAME VALUE" where the type of value depends on PREFNAME)
  forced children to be prediction-less. This allows them to decide for themselves

* The file type assumed that the local filesystem was the same as the remote one
  which is clearly wrong. The change to gcli/types/file fixes that.

* Typo fix to gcli/util/util

* On very slow connections gcli/cli.js could get in a pickle where 2 changes
  happened out of order. We've planned for this, but got in wrong, so this just
  adds a bit of defensive programming.

Comment 1

[Joe Walker [:jwalker]]

Attachment: MozReview Request: Bug 1253221 - Sync changes from GCLI web project; r=jryans

Changes in this patch:
* GCLI gave up with testing via phantomjs a while ago, but the docs didn't keep
  up, so this fixes the docs.
* gcli/languages/command isn't used in Firefox, but on the web if a converter
  wrongly produces a null DOM node, then the UI just looks blank, so this change
  makes the error more obvious. However we don't use this in Firefox. I'd like to
  remove the module, but not in this patch.
* The delegate type (used when we want to defer the type of a parameter, e.g.
  with "pref set PREFNAME VALUE" where the type of value depends on PREFNAME)
  forced children to be prediction-less. This allows them to decide for themselves
* The file type assumed that the local filesystem was the same as the remote one
  which is clearly wrong. The change to gcli/types/file fixes that.
* Typo fix to gcli/util/util
* On very slow connections gcli/cli.js could get in a pickle where 2 changes
  happened out of order. We've planned for this, but got in wrong, so this just
  adds a bit of defensive programming.

Review commit: https://reviewboard.mozilla.org/r/37851/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37851/

Comment 2

[Joe Walker [:jwalker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0468dfd1ee0

(It doesn't show up on the change log, because I previously pushed a broken patch on top of it, but it is the parent of the commits that you can see)

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8726207 [details]
MozReview Request: Bug 1253221 - Sync changes from GCLI web project; r=jryans

https://reviewboard.mozilla.org/r/37851/#review34459

::: devtools/shared/gcli/source/lib/gcli/cli.js:1173
(Diff revision 1)
> +    if (argTrace.part === 'text' && arg.assignment != null) {

Aha, I think I've seen occasional stacks logged about this...

Comment 4

[Joe Walker [:jwalker]]

Comment on attachment 8726207 [details]
MozReview Request: Bug 1253221 - Sync changes from GCLI web project; r=jryans

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37851/diff/1-2/

Comment 5

[Joe Walker [:jwalker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63a90f078149

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92eb1555b47c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92eb1555b47c