Closed
Bug 1253236
Opened 8 years ago
Closed 8 years ago
Rename element.checkVisible to isVisible
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(3 files)
Unlike accessibility.checkVisible it does not perform an assertion, and should be renamed to isVisible. There is also some code duplication with regards to element.isXULElement that can be reduced.
Assignee | ||
Updated•8 years ago
|
Keywords: ateam-marionette-server
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37859/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37859/
Attachment #8726216 -
Flags: review?(dburns)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37861/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37861/
Attachment #8726217 -
Flags: review?(dburns)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37863/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37863/
Attachment #8726218 -
Flags: review?(dburns)
Comment 4•8 years ago
|
||
Comment on attachment 8726216 [details] MozReview Request: Bug 1253236 - Rename element.checkVisible to isVisible; r?automatedtester https://reviewboard.mozilla.org/r/37859/#review34771
Attachment #8726216 -
Flags: review?(dburns) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8726217 [details] MozReview Request: Bug 1253236 - Remove window argument from element.isVisible; r?automatedtester https://reviewboard.mozilla.org/r/37861/#review34773
Attachment #8726217 -
Flags: review?(dburns) → review+
Updated•8 years ago
|
Attachment #8726218 -
Flags: review?(dburns) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8726218 [details] MozReview Request: Bug 1253236 - Reuse element.isXULElement; r?automatedtester https://reviewboard.mozilla.org/r/37863/#review34775
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf253e3a840 https://hg.mozilla.org/integration/mozilla-inbound/rev/746ba7188bcf https://hg.mozilla.org/integration/mozilla-inbound/rev/660bdaf64326
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3cf253e3a840 https://hg.mozilla.org/mozilla-central/rev/746ba7188bcf https://hg.mozilla.org/mozilla-central/rev/660bdaf64326
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•