1253242 - Make it more difficult to accidently signoff Lightning (as it uses Thunderbird's signoffs)

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Elmo, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Attachment: Template patch to replace the signoff button with a link for Lightning

Lightning doesn't have separate signoffs, but the buttons to signoff are still there and currently have to be disabled each time trees are uplifted.

Here's a patch for the template, which hides the signoff button for Lightning and instead adds a small link to the Thunderbird section telling to Signoff that instead.

Comment 1

[Axel Hecht [:Pike]]

Comment on attachment 8726215 [details] [diff] [review]
Template patch to replace the signoff button with a link for Lightning

Review of attachment 8726215 [details] [diff] [review]:
-----------------------------------------------------------------

Nah, that's the wrong place to do any of this.

Any fix for lightning would require to get the data model right, and then the UX would fall out of that.

Comment 2

[Axel Hecht [:Pike]]

i'm marking this WONTFIX, because it's the wrong way to address the problem of lighting sign-offs.

The right fix is somewhere in the land of the release migration stuff, where we do optional fallbacks.