Closed
Bug 1253244
Opened 8 years ago
Closed 8 years ago
Use element.coordinates in listener
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox47 fixed, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(3 files)
listener.js currently has its own function to retrieve coordinates. This is not needed because there is one in the testing/marionette/element.js module, called element.coordinates.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37867/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37867/
Attachment #8726220 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37869/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37869/
Attachment #8726222 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•8 years ago
|
||
There are some test failures in the try run, and I will fix those soon.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8726220 [details] MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37867/diff/1-2/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8726222 [details] MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37869/diff/1-2/
|
|
Assignee | |
Comment 6•8 years ago
|
||
The xOffset and yOffset arguments to element.coordinates previously checked loose falsiness. If a number <= 0 would be given as an argument, they would not be used and it would return the centre of the element. This change adds more checks, documentation, and tests. Review commit: https://reviewboard.mozilla.org/r/38223/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38223/
Attachment #8726751 -
Flags: review?(dburns)
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8726220 [details] MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester https://reviewboard.mozilla.org/r/37867/#review34781
Attachment #8726220 -
Flags: review?(dburns) → review+
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8726222 [details] MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester https://reviewboard.mozilla.org/r/37869/#review34785
Attachment #8726222 -
Flags: review?(dburns) → review+
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8726751 [details] MozReview Request: Bug 1253244 - Correct x,y offset type checks and add tests; r?automatedtester https://reviewboard.mozilla.org/r/38223/#review34789
Attachment #8726751 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 10•8 years ago
|
||
Comment on attachment 8726220 [details] MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37867/diff/2-3/
|
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8726222 [details] MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37869/diff/2-3/
|
|
Assignee | |
Comment 12•8 years ago
|
||
Comment on attachment 8726751 [details] MozReview Request: Bug 1253244 - Correct x,y offset type checks and add tests; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38223/diff/1-2/
|
||
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c64f5448df4a https://hg.mozilla.org/integration/mozilla-inbound/rev/7efc942f08ea https://hg.mozilla.org/integration/mozilla-inbound/rev/a62776417e00
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c64f5448df4a https://hg.mozilla.org/mozilla-central/rev/7efc942f08ea https://hg.mozilla.org/mozilla-central/rev/a62776417e00
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
|
||
Comment 15•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/32d5e7815729 https://hg.mozilla.org/releases/mozilla-aurora/rev/f565c27537b5 https://hg.mozilla.org/releases/mozilla-aurora/rev/6405c7fb1a53
status-firefox47:
--- → fixed
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•