Use element.coordinates in listener

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({pi-marionette-server})

Version 3
mozilla48
Points:
---

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed)

Details

Attachments

(3 attachments)

listener.js currently has its own function to retrieve coordinates.  This is not needed because there is one in the testing/marionette/element.js module, called element.coordinates.
Assignee: nobody → ato
Status: NEW → ASSIGNED
There are some test failures in the try run, and I will fix those soon.
Comment on attachment 8726220 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37867/diff/1-2/
Comment on attachment 8726222 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37869/diff/1-2/
The xOffset and yOffset arguments to element.coordinates previously
checked loose falsiness.  If a number <= 0 would be given as an argument,
they would not be used and it would return the centre of the element.

This change adds more checks, documentation, and tests.

Review commit: https://reviewboard.mozilla.org/r/38223/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38223/
Attachment #8726751 - Flags: review?(dburns)
Comment on attachment 8726220 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester

https://reviewboard.mozilla.org/r/37867/#review34781
Attachment #8726220 - Flags: review?(dburns) → review+
Comment on attachment 8726222 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester

https://reviewboard.mozilla.org/r/37869/#review34785
Attachment #8726222 - Flags: review?(dburns) → review+
Comment on attachment 8726751 [details]
MozReview Request: Bug 1253244 - Correct x,y offset type checks and add tests; r?automatedtester

https://reviewboard.mozilla.org/r/38223/#review34789
Attachment #8726751 - Flags: review?(dburns) → review+
Comment on attachment 8726220 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in listener; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37867/diff/2-3/
Comment on attachment 8726222 [details]
MozReview Request: Bug 1253244 - Use element.coordinates in action module; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37869/diff/2-3/
Comment on attachment 8726751 [details]
MozReview Request: Bug 1253244 - Correct x,y offset type checks and add tests; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38223/diff/1-2/
https://hg.mozilla.org/mozilla-central/rev/c64f5448df4a
https://hg.mozilla.org/mozilla-central/rev/7efc942f08ea
https://hg.mozilla.org/mozilla-central/rev/a62776417e00
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.