Closed Bug 1253248 Opened 7 years ago Closed 7 years ago

Use element.Strategies enum in element module

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed, firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester
58 bytes, text/x-review-board-request
automatedtester
: review+
Details 
The testing/marionette/element.js module refers to element location strategies inconsistently.  It ought to use the element.Strategies enum.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
Removes the exported constants from testing/marionette/element.js and
introduces the migrates to using the element.Strategy enum consistently
throughout Marionette.

The supported strategies array passed into ElementManager's ctor has
also received some much needed attention and now actually works.

Review commit: https://reviewboard.mozilla.org/r/38185/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38185/
Attachment #8726679 - Flags: review?(dburns)
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38185/diff/1-2/
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

https://reviewboard.mozilla.org/r/38185/#review34797
Attachment #8726679 - Flags: review?(dburns) → review+
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38185/diff/2-3/
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38185/diff/3-4/
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38185/diff/4-5/
Comment on attachment 8726679 [details]
MozReview Request: Bug 1253248 - Use element.Strategy enum consistently; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38185/diff/5-6/
https://hg.mozilla.org/mozilla-central/rev/a0ec2ec1f004
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.