1253314 - TC Linux 32 opt / PGO builds Tier-2

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Selena Deckelmann :selenamarie :selena]

This is a planning bug for tracking work related to getting Linux 32 Opt / PGO builds Tier-2.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1253314 - enable Linux32 PGO builds.

***
stuff

***
stuff

Review commit: https://reviewboard.mozilla.org/r/80970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80970/

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: Initially used the "old-fashioned way" approach as Linux64-PGO here[0] but failed due to Schema Validation Failed in "data.routes should NOT have more than 10 items" as per [1]. Removed the two index.buildbot.... routes and tried again at [2]. Eventually, adapted to the new build kind implementation under gecko/taskcluster and pushed patch.

@dustin
Do I need to tweak the coalescer[3] as well to reflect the linux32-pgo too?

[0]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4095e50f9a0&selectedJob=28022318
[1]: https://public-artifacts.taskcluster.net/SDO7F07pR-aDcirMv3nD4g/0/public/logs/live_backing.log
[2]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e53160cfe608
[3]: https://coalesce.mozilla-releng.net/v1/threshold

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.

https://reviewboard.mozilla.org/r/80970/#review79748

Looks good!

Please rewrite the commit message -- I assume that's an `hg histedit` gone wrong :)

::: taskcluster/taskgraph/transforms/gecko_v2_whitelist.py:44
(Diff revision 1)
>      'linux64-pgo',
>      'linux64-st-an-opt',
>      'linux64-valgrind-opt',
>      'linux-debug',
>      'linux-opt',
> +    'linux-pgo',

Good, this matches
  https://tools.taskcluster.net/index/#gecko.v2.mozilla-central.latest.firefox/gecko.v2.mozilla-central.latest.firefox.linux-pgo

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80970/diff/1-2/

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

@dustin: amended the commits message. Sorry again for folding instead of roling. Will keep that in mind.
When you have a spare minute, please land this for me as I don't have level3 to push to inbound.

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff35e4bcc7c8
enable Linux32 PGO builds. r=dustin

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/47f858388a98 since what you got was https://treeherder.mozilla.org/logviewer.html#?job_id=4026208&repo=autoland

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80970/diff/2-3/

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

@dustin:

My bad, sorry for that, I forgot a trailing ".py" extension in the config file. I've reuploaded to review.
The same as yesterday, when reviewed - please land it for me.
Thanks!

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.

https://reviewboard.mozilla.org/r/80970/#review80278

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30f0eae664b4
enable Linux32 PGO builds. r=dustin

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/30f0eae664b4