Closed Bug 1253314 Opened 4 years ago Closed 3 years ago

TC Linux 32 opt / PGO builds Tier-2

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla52

People

(Reporter: selenamarie, Assigned: mtabara)

References

Details

Attachments

(1 file)

This is a planning bug for tracking work related to getting Linux 32 Opt / PGO builds Tier-2.
Assignee: nobody → mtabara
See Also: → 1253298
Blocks: 1303683
Note to self: Initially used the "old-fashioned way" approach as Linux64-PGO here[0] but failed due to Schema Validation Failed in "data.routes should NOT have more than 10 items" as per [1]. Removed the two index.buildbot.... routes and tried again at [2]. Eventually, adapted to the new build kind implementation under gecko/taskcluster and pushed patch.

@dustin
Do I need to tweak the coalescer[3] as well to reflect the linux32-pgo too?

[0]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4095e50f9a0&selectedJob=28022318
[1]: https://public-artifacts.taskcluster.net/SDO7F07pR-aDcirMv3nD4g/0/public/logs/live_backing.log
[2]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e53160cfe608
[3]: https://coalesce.mozilla-releng.net/v1/threshold
Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.

https://reviewboard.mozilla.org/r/80970/#review79748

Looks good!

Please rewrite the commit message -- I assume that's an `hg histedit` gone wrong :)

::: taskcluster/taskgraph/transforms/gecko_v2_whitelist.py:44
(Diff revision 1)
>      'linux64-pgo',
>      'linux64-st-an-opt',
>      'linux64-valgrind-opt',
>      'linux-debug',
>      'linux-opt',
> +    'linux-pgo',

Good, this matches
  https://tools.taskcluster.net/index/#gecko.v2.mozilla-central.latest.firefox/gecko.v2.mozilla-central.latest.firefox.linux-pgo
Attachment #8794600 - Flags: review?(dustin) → review+
@dustin: amended the commits message. Sorry again for folding instead of roling. Will keep that in mind.
When you have a spare minute, please land this for me as I don't have level3 to push to inbound.

Thanks!
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff35e4bcc7c8
enable Linux32 PGO builds. r=dustin
@dustin:

My bad, sorry for that, I forgot a trailing ".py" extension in the config file. I've reuploaded to review.
The same as yesterday, when reviewed - please land it for me.
Thanks!
https://hg.mozilla.org/mozilla-central/rev/30f0eae664b4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.