Closed Bug 1253327 Opened 5 years ago Closed 5 years ago

Fix direction of children-pointer in RTL

Categories

(DevTools :: Memory, defect, P3)

defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: fitzgen, Assigned: steveck)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Hi magicp, I think this issue is fixed after Bug 1205590 landed. Could you verify that?
Flags: needinfo?(magicp.jp)
(In reply to Steve Chung [:steveck] from comment #1)
> Hi magicp, I think this issue is fixed after Bug 1205590 landed. Could you
> verify that?

Hi Steve, twisty was fixed. But child-pointer still have this issue.
Flags: needinfo?(magicp.jp)
Summary: Fix direction of twisty and children-pointer in RTL → Fix direction of children-pointer in RTL
Comment on attachment 8782747 [details]
Bug 1253327 - Fix direction of children-pointer in RTL.

https://reviewboard.mozilla.org/r/72792/#review70524

::: devtools/client/themes/memory.css:398
(Diff revision 1)
>  
>  .children-pointer {
>    padding-inline-end: 5px;
>  }
>  
> +.children-pointer:-moz-locale-dir(rtl),

I think we might not need the :-moz-locale-dir(rtl) since it's based on HTML in the memory panel(and it seems the memory.css won't apply to other xul element).
Comment on attachment 8782747 [details]
Bug 1253327 - Fix direction of children-pointer in RTL.

https://reviewboard.mozilla.org/r/72790/#review70890

Works locally!
r=me with :-moz-locale-dir removed.
Comment on attachment 8782747 [details]
Bug 1253327 - Fix direction of children-pointer in RTL.

https://reviewboard.mozilla.org/r/72792/#review70708

::: devtools/client/themes/memory.css:398
(Diff revision 1)
>  
>  .children-pointer {
>    padding-inline-end: 5px;
>  }
>  
> +.children-pointer:-moz-locale-dir(rtl),
Attachment #8782747 - Flags: review?(ntim.bugs) → review+
Assignee: nobody → schung
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f03e82447575
Fix direction of children-pointer in RTL. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f03e82447575
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I have checked this in latest Nightly Build(20160823072522). The padding of children-pointer should be changed for RTL locales. Please find attached image.
Oops... Sorry we missed the padding end would be mirrored accidentally. Should we file another bug for this?
Flags: needinfo?(magicp.jp)
Can I reopen this?
Flags: needinfo?(magicp.jp)
Product: Firefox → DevTools
Blocks: 1585890
You need to log in before you can comment on or make changes to this bug.