Closed Bug 1253333 Opened 5 years ago Closed 5 years ago

Race condition in NotifyFinished() - called after MediaManager shuts down

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

The AsyncShutdown hang I started hitting in bug 1250934 was due to a race where NotifyFinished (from MSG) happened after MediaManager shuts down.  Calling Get() was causing a second MediaManager to be created, which we have an assert for in debug.
MOZ_RELEASE_ASSERT is the bomb.
Comment on attachment 8726286 [details] [diff] [review]
Don't cause a second MediaManager to be created if there's a race with NotifyFinished

Review of attachment 8726286 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. It's a little troubling knowing stuff is going on this late.
Attachment #8726286 - Flags: review?(jib) → review+
Rank: 15
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/42356eefad43
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.