Race condition in NotifyFinished() - called after MediaManager shuts down

RESOLVED FIXED in Firefox 48

Status

()

P1
normal
Rank:
15
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox47 affected, firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The AsyncShutdown hang I started hitting in bug 1250934 was due to a race where NotifyFinished (from MSG) happened after MediaManager shuts down.  Calling Get() was causing a second MediaManager to be created, which we have an assert for in debug.
MOZ_RELEASE_ASSERT is the bomb.
(Assignee)

Comment 2

3 years ago
Created attachment 8726286 [details] [diff] [review]
Don't cause a second MediaManager to be created if there's a race with NotifyFinished

MozReview-Commit-ID: J4GArKKncYx
Attachment #8726286 - Flags: review?(jib)
Comment on attachment 8726286 [details] [diff] [review]
Don't cause a second MediaManager to be created if there's a race with NotifyFinished

Review of attachment 8726286 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. It's a little troubling knowing stuff is going on this late.
Attachment #8726286 - Flags: review?(jib) → review+
(Assignee)

Updated

3 years ago
Rank: 15
Priority: -- → P1

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/42356eefad43
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.