Closed Bug 1253370 Opened 4 years ago Closed 4 years ago

Shared memory spec change: ValidateAtomicAccess algorithm change

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://github.com/tc39/ecmascript_sharedmem/issues/78

The algorithm has changed to correspond to what the DataView methods do and what the SIMD methods will do.
We should reuse the ArgumentToIntegerIndex function that Jakob developed for bug 1252270: https://bugzilla.mozilla.org/show_bug.cgi?id=1252270#c6
Attachment #8734423 - Flags: review?(jolesen)
Comment on attachment 8734423 [details] [diff] [review]
make atomics range checking conformant

Review of attachment 8734423 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: js/src/jit-test/tests/atomics/basic-tests.js
@@ +215,5 @@
>  
>      assertErrorMessage(() => Atomics.compareExchange(a, -1, 0, 1), RangeError, msg);
>      assertEq(a[0], 0);
>  
>      assertErrorMessage(() => Atomics.compareExchange(a, "hi", 0, 1), RangeError, msg);

Perhaps add a test with a string index that was previously not allowed, e.g. " 0x3".
Attachment #8734423 - Flags: review?(jolesen) → review+
Landed with the wrong number yesterday.
https://hg.mozilla.org/mozilla-central/rev/71eb251a0f29
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.